From: Ben Greear <greearb@candelatech.com>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: netdev@vger.kernel.org
Subject: Re: [patch] add net_device_stats support to ethtool
Date: Wed, 16 Jan 2008 10:03:34 -0800 [thread overview]
Message-ID: <478E46F6.4070901@candelatech.com> (raw)
In-Reply-To: <200801161529.m0GFTfYR005096@sallyv1.ics.uci.edu>
Dan Nicolaescu wrote:
> Hi,
>
> I have posted this patch in the past with absolutely no reply.
> I would appreciate some sort of feedback of the form
> interested/not interested. Should I just drop it?
>
>
I like it, but why not offer this for all devices since they all have
these stats.
Could add new handlers called something like .get_strings_generic, or
just add this to the higher-level ethtool handling before it looks for
handlers.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2008-01-16 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 15:29 [patch] add net_device_stats support to ethtool Dan Nicolaescu
2008-01-16 18:03 ` Ben Greear [this message]
2008-01-16 18:34 ` Dan Nicolaescu
2008-01-16 18:46 ` Ben Greear
2008-01-17 5:13 ` Dan Nicolaescu
2008-01-18 20:14 ` Jeff Garzik
2008-01-18 22:01 ` Dan Nicolaescu
-- strict thread matches above, loose matches on Subject: below --
2006-12-04 17:06 Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478E46F6.4070901@candelatech.com \
--to=greearb@candelatech.com \
--cc=dann@ics.uci.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).