netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@sw.ru>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	Linux Containers <containers@lists.osdl.org>,
	devel@openvz.org
Subject: [PATCH 0/4 net-2.6.25] Proper netlink kernel sockets disposal.
Date: Fri, 18 Jan 2008 15:51:47 +0300	[thread overview]
Message-ID: <4790A0E3.9080006@sw.ru> (raw)

Alexey Dobriyan found, that virtualized netlink kernel sockets (fibl &
rtnl) are leaked during namespace start/stop loop.

Leaking fix (simple and obvious) reveals that netlink kernel socket
disposal leads to OOPSes:
- nl_table[protocol]->listeners is double freed
- sometimes during namespace stop netlink_sock_destruct
  BUG_TRAP(!atomic_read(&sk->sk_rmem_alloc)); is hit

This set address all these issues.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Tested-by: Alexey Dobriayn <adobriyan@openvz.org>


             reply	other threads:[~2008-01-18 12:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18 12:51 Denis V. Lunev [this message]
2008-01-18 12:53 ` [PATCH] [NETNS 1/4 net-2.6.25] Double free in netlink_release Denis V. Lunev
2008-01-18 12:53 ` [PATCH] [NETNS 2/4 net-2.6.25] Memory leak on network namespace stop Denis V. Lunev
2008-01-18 12:53 ` [PATCH ] [NETNS 3/4 net-2.6.25] Consolidate kernel netlink socket destruction Denis V. Lunev
2008-01-18 12:53 ` [PATCH] [NETNS 4/4 net-2.6.25] Namespace stop vs 'ip r l' race Denis V. Lunev
2008-01-19  7:55 ` [PATCH 0/4 net-2.6.25] Proper netlink kernel sockets disposal David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4790A0E3.9080006@sw.ru \
    --to=den@sw.ru \
    --cc=containers@lists.osdl.org \
    --cc=davem@davemloft.net \
    --cc=devel@openvz.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).