netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
	Andy Gospodarek <andy@greyhouse.net>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/7] bonding: fix locking in sysfs primary/active selection
Date: Fri, 18 Jan 2008 14:39:02 -0500	[thread overview]
Message-ID: <47910056.5070603@pobox.com> (raw)
In-Reply-To: <12006159063217-git-send-email-fubar@us.ibm.com>

Jay Vosburgh wrote:
> 	Fix the functions that store the primary and active slave
> options via sysfs to hold the correct locks in the correct order.
> 
> 	The bond_change_active_slave and bond_select_active_slave
> functions both require rtnl, bond->lock for read and curr_slave_lock for
> write_bh, and no other locks.  This is so that the lower level
> mode-specific functions (notably for balance-alb mode) can release locks
> down to just rtnl in order to call, e.g., dev_set_mac_address with the
> locks it expects (rtnl only).
> 
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
> ---
>  drivers/net/bonding/bond_sysfs.c |   15 ++++++++++-----
>  1 files changed, 10 insertions(+), 5 deletions(-)

applied 1-7



  parent reply	other threads:[~2008-01-18 19:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18  0:24 [PATCH 0/7] bonding: 7 fixes for 2.6.24 Jay Vosburgh
2008-01-18  0:24 ` [PATCH 1/7] bonding: fix locking in sysfs primary/active selection Jay Vosburgh
2008-01-18  0:24   ` [PATCH 2/7] bonding: fix ASSERT_RTNL that produces spurious warnings Jay Vosburgh
2008-01-18  0:24     ` [PATCH 3/7] bonding: fix locking during alb failover and slave removal Jay Vosburgh
2008-01-18  0:25       ` [PATCH 4/7] bonding: release slaves when master removed via sysfs Jay Vosburgh
2008-01-18  0:25         ` [PATCH 5/7] bonding: Fix up parameter parsing Jay Vosburgh
2008-01-18  0:25           ` [PATCH 6/7] bonding: fix lock ordering for rtnl and bonding_rwsem Jay Vosburgh
2008-01-18  0:25             ` [PATCH 7/7] bonding: Don't hold lock when calling rtnl_unlock Jay Vosburgh
2008-01-18  0:38             ` [PATCH 6/7] bonding: fix lock ordering for rtnl and bonding_rwsem Andrew Morton
2008-01-18 19:39   ` Jeff Garzik [this message]
2008-01-21  1:15 ` [PATCH 0/7] bonding: 7 fixes for 2.6.24 David Miller
2008-01-21  1:36   ` Andrew Morton
2008-01-21  3:58     ` David Miller
2008-01-21  1:57   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47910056.5070603@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@linux-foundation.org \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).