From: Jeff Garzik <jgarzik@pobox.com>
To: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Cc: netdev@vger.kernel.org
Subject: Re: [patch v3] Documentation: add a guideline for hard_start_xmit method
Date: Fri, 18 Jan 2008 14:42:13 -0500 [thread overview]
Message-ID: <47910115.2030102@pobox.com> (raw)
In-Reply-To: <492102.15643.qm@web52012.mail.re2.yahoo.com>
Matti Linnanvuori wrote:
> From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
>
> Add a guideline not to modify SKBs.
>
> Signed-off-by: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
>
> ---
>
> --- a/Documentation/networking/driver.txt 2008-01-13 07:14:01.608291500 +0200
> +++ b/Documentation/networking/driver.txt 2008-01-15 16:16:14.636054000 +0200
> @@ -61,7 +61,10 @@ Transmit path guidelines:
> 2) Do not forget to update netdev->trans_start to jiffies after
> each new tx packet is given to the hardware.
>
> -3) Do not forget that once you return 0 from your hard_start_xmit
> +3) A hard_start_xmit method must not modify the shared parts of a
> + cloned SKB.
> +
> +4) Do not forget that once you return 0 from your hard_start_xmit
> method, it is your driver's responsibility to free up the SKB
> and in some finite amount of time.
applied
prev parent reply other threads:[~2008-01-18 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 14:25 [patch v3] Documentation: add a guideline for hard_start_xmit method Matti Linnanvuori
2008-01-18 19:42 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47910115.2030102@pobox.com \
--to=jgarzik@pobox.com \
--cc=mattilinnanvuori@yahoo.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).