netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: slavon@bigtelecom.ru, netdev@vger.kernel.org
Subject: Re: Packetlost when "tc qdisc del dev eth0 root"
Date: Sun, 20 Jan 2008 00:21:56 +0100	[thread overview]
Message-ID: <47928614.1090209@gmail.com> (raw)
In-Reply-To: <478D9222.7030603@trash.net>

Patrick McHardy wrote, On 01/16/2008 06:12 AM:

> slavon@bigtelecom.ru wrote:
>> Good night! =)
>>
>> Sorry... i was wrong...
>> I see that problem more serious....
>>
>> Lets see to scheme
>>
>> Class 1
>> ---qdisc
>> ------- 10k classes
>> Class 2
>> ---qdisc
>> ------- 10k classes
>>
>> All traffic go to class 2... class 1 qdisc not have packets and if we 
>> delete it - packets not lost... in theory... lets try delete class 1 
>> qdisc (all childrens delete too)...
>> PC freeze on 2-5 seconds... its not forward any traffic at this 
>> moment... its great tree lock?
>>
>> Its normal or code need to more accurate lock?
> 
> 
> htb class destruction can be quite expansive if one of the rb trees
> needs to be rebalanced. Doing that for 10000 classes would explain
> the delay.

I've just looked at this and it seems there should be no rbtrees operations
during htb qdisc deletion (or I miss something).

Slavon, I see nearby that you teach oprofile...

Regards,
Jarek P.

  reply	other threads:[~2008-01-19 23:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-15 11:10 Packetlost when "tc qdisc del dev eth0 root" Badalian Vyacheslav
2008-01-15 16:05 ` Patrick McHardy
2008-01-15 16:11   ` slavon
2008-01-15 21:15   ` Jarek Poplawski
2008-01-15 21:46     ` slavon
2008-01-15 22:04       ` slavon
2008-01-15 22:49         ` Jarek Poplawski
2008-01-16  5:12         ` Patrick McHardy
2008-01-19 23:21           ` Jarek Poplawski [this message]
2008-01-15 22:32       ` Jarek Poplawski
2008-01-15 23:16       ` Glen Turner
2008-01-16  5:02     ` Patrick McHardy
2008-01-16  8:02       ` Jarek Poplawski
2008-01-16  8:05         ` Patrick McHardy
2008-01-16  8:35           ` Badalian Vyacheslav
2008-01-16  9:42             ` Jarek Poplawski
2008-01-16  8:52           ` Jarek Poplawski
2008-01-16  8:54             ` Badalian Vyacheslav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47928614.1090209@gmail.com \
    --to=jarkao2@gmail.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=slavon@bigtelecom.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).