netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org
Subject: Re: [Bugme-new] [Bug 9758] New: net_device refcnt bug when NFQUEUEing bridged packets
Date: Sun, 20 Jan 2008 14:58:46 +0100	[thread overview]
Message-ID: <47935396.2080509@trash.net> (raw)
In-Reply-To: <20080116105632.2532812c@speedy>

Stephen Hemminger wrote:
> This looks good, but you could use a structure assignment rather memcpy
> (just a personal style preference because assignment is typed and memcpy
> is not).

That doesn't work in this case since nf_bridge_info contains

         unsigned long data[32 / sizeof(unsigned long)];

and I don't want to assign each array element seperately.

      reply	other threads:[~2008-01-20 13:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-9758-10286@http.bugzilla.kernel.org/>
2008-01-15 23:56 ` [Bugme-new] [Bug 9758] New: net_device refcnt bug when NFQUEUEing bridged packets Andrew Morton
2008-01-16  4:54   ` Patrick McHardy
2008-01-16  4:59     ` Patrick McHardy
2008-01-16 18:56       ` Stephen Hemminger
2008-01-20 13:58         ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47935396.2080509@trash.net \
    --to=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).