From: Wang Chen <wangchen@cn.fujitsu.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: David L Stevens <dlstevens@us.ibm.com>,
netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: [PATCH 1/2] IPV6: ICMP6_MIB_OUTMSGS increment duplicated
Date: Mon, 21 Jan 2008 17:46:32 +0800 [thread overview]
Message-ID: <479469F8.4010203@cn.fujitsu.com> (raw)
In-Reply-To: <478DD57B.6020503@cn.fujitsu.com>
[IPV6]: ICMP6_MIB_OUTMSGS increment duplicated
icmpv6_send() calls ip6_push_pending_frames() indirectly.
Both ip6_push_pending_frames() and icmpv6_send() increment
counter ICMP6_MIB_OUTMSGS.
This patch remove the increment from icmpv6_send.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
--- linux-2.6.24.rc8.org/net/ipv6/icmp.c 2008-01-16 17:45:03.000000000 +0800
+++ linux-2.6.24.rc8/net/ipv6/icmp.c 2008-01-21 15:56:06.000000000 +0800
@@ -458,8 +458,6 @@ void icmpv6_send(struct sk_buff *skb, in
}
err = icmpv6_push_pending_frames(sk, &fl, &tmp_hdr, len + sizeof(struct icmp6hdr));
- ICMP6_INC_STATS_BH(idev, ICMP6_MIB_OUTMSGS);
-
out_put:
if (likely(idev != NULL))
in6_dev_put(idev);
next prev parent reply other threads:[~2008-01-21 9:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 9:59 [PATCH] ICMP: ICMP_MIB_OUTMSGS increment duplicated Wang Chen
2008-01-16 11:49 ` Herbert Xu
2008-01-16 16:23 ` David Stevens
2008-01-16 23:17 ` Herbert Xu
2008-01-17 0:10 ` David Stevens
2008-01-17 0:55 ` Wang Chen
2008-01-21 9:46 ` Wang Chen [this message]
2008-01-21 9:59 ` [PATCH 1/2] IPV6: ICMP6_MIB_OUTMSGS " YOSHIFUJI Hideaki / 吉藤英明
2008-01-21 10:57 ` David Miller
2008-01-21 10:59 ` Wang Chen
2008-01-21 11:06 ` David Miller
2008-01-21 11:12 ` Wang Chen
2008-01-21 9:46 ` [PATCH 2/2] IPV6: RFC 2011 compatibility broken Wang Chen
2008-01-21 9:58 ` YOSHIFUJI Hideaki / 吉藤英明
2008-01-21 19:17 ` David Stevens
2008-01-21 11:15 ` [PATCH] ICMP: ICMP_MIB_OUTMSGS increment duplicated Wang Chen
2008-01-21 11:25 ` David Miller
2008-01-21 11:34 ` Wang Chen
2008-01-21 11:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479469F8.4010203@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).