From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [IPV4 0/9] TRIE performance patches Date: Wed, 23 Jan 2008 08:31:05 -0800 Message-ID: <47976BC9.3020801@linux-foundation.org> References: <20080122233733.404145234@linux-foundation.org> <18327.18935.137799.285515@robur.slu.se> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org To: Robert Olsson Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:34243 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbYAWQao (ORCPT ); Wed, 23 Jan 2008 11:30:44 -0500 In-Reply-To: <18327.18935.137799.285515@robur.slu.se> Sender: netdev-owner@vger.kernel.org List-ID: Robert Olsson wrote: > Stephen Hemminger writes: > > > Time to handle a full BGP load (163K of routes). > > > > Before: Load Dump Flush > > > > kmem_cache 3.8 13.0 7.2 > > iter 3.9 12.3 6.9 > > unordered 3.1 11.9 4.9 > > find_node 3.1 0.3 1.2 > > I certainly like the speed but what will we brake when > we don't return in longest prefix order? > > labb:/# ip r > default via 10.10.10.1 dev eth0 > 5.0.0.0/8 via 192.168.2.2 dev eth3 > 10.10.10.0/24 dev eth0 proto kernel scope link src 10.10.10.2 > 10.10.11.0/24 dev eth1 proto kernel scope link src 10.10.11.1 > 11.0.0.0/8 via 10.10.11.2 dev eth1 > 192.168.1.0/24 dev eth2 proto kernel scope link src 192.168.1.2 > 192.168.2.0/24 dev eth3 proto kernel scope link src 192.168.2.1 > > labb:/# ip route list match 10.10.10.1 > default via 10.10.10.1 dev eth0 > 10.10.10.0/24 dev eth0 proto kernel scope link src 10.10.10.2 > labb:/# > > Maybe the unordered dump can be ordered cheaply... > > Cheers. > --ro > > Hash returned the routes in prefix order (then random). Returning the routes in numerical order seems just as logical. I'm going to test on quagga.