[PATCH] net: mctp: Remove unnecessary cast in mctp_cb

[PATCH] net: mctp: Remove unnecessary cast in mctp_cb

[Herbert Xu]

The void * cast in mctp_cb is unnecessary as it's already been done
at the start of the function.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/include/net/mctp.h b/include/net/mctp.h
index 1ecbff7116f6..07d458990113 100644
--- a/include/net/mctp.h
+++ b/include/net/mctp.h
@@ -212,7 +212,7 @@ static inline struct mctp_skb_cb *mctp_cb(struct sk_buff *skb)
 
 	BUILD_BUG_ON(sizeof(struct mctp_skb_cb) > sizeof(skb->cb));
 	WARN_ON(cb->magic != 0x4d435450);
-	return (void *)(skb->cb);
+	return cb;
 }
 
 /* If CONFIG_MCTP_FLOWS, we may add one of these as a SKB extension,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] net: mctp: Remove unnecessary cast in mctp_cb

[Jeremy Kerr]

Hi Herbert,

> The void * cast in mctp_cb is unnecessary as it's already been done
> at the start of the function.

Thanks for the change, all looks good to me, and now we're consistent
with __mctp_cb() above.

Acked-by: Jeremy Kerr <jk@codeconstruct.com.au>

Cheers,


Jeremy

Re: [PATCH] net: mctp: Remove unnecessary cast in mctp_cb

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Fri, 14 Mar 2025 17:00:41 +0800 you wrote:
> The void * cast in mctp_cb is unnecessary as it's already been done
> at the start of the function.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Here is the summary with links:
  - net: mctp: Remove unnecessary cast in mctp_cb
    https://git.kernel.org/netdev/net-next/c/a6984aa806c8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html