From: Patrick McHardy <kaber@trash.net>
To: Rami Rosen <ramirose@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.
Date: Tue, 29 Jan 2008 16:19:04 +0100 [thread overview]
Message-ID: <479F43E8.4010107@trash.net> (raw)
In-Reply-To: <eb3ff54b0801290714ja7e7e67t3349028b7db8dc5e@mail.gmail.com>
Rami Rosen wrote:
> Hi,
> In drivers/net/macvlan.c, when rtnl_link_register() fails
> in macvlan_init_module(), there is no point to set it (second time in this
> method) to macvlan_handle_frame; macvlan_init_module() will return a negative
> number, so instead this patch sets macvlan_handle_frame_hook to NULL.
Indeed, that seems to be a stupid cut-and-paste error. Thanks for
catching this.
Dave, please apply.
next prev parent reply other threads:[~2008-01-29 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 15:14 [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails Rami Rosen
2008-01-29 15:19 ` Patrick McHardy [this message]
2008-02-01 0:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479F43E8.4010107@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).