* [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.
@ 2008-01-29 15:14 Rami Rosen
2008-01-29 15:19 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: Rami Rosen @ 2008-01-29 15:14 UTC (permalink / raw)
To: kaber, netdev
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
Hi,
In drivers/net/macvlan.c, when rtnl_link_register() fails
in macvlan_init_module(), there is no point to set it (second time in this
method) to macvlan_handle_frame; macvlan_init_module() will return a negative
number, so instead this patch sets macvlan_handle_frame_hook to NULL.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <ramirose@gmail.com>
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 405 bytes --]
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 6ef6b8b..f651a81 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -508,7 +508,7 @@ static int __init macvlan_init_module(void)
goto err1;
return 0;
err1:
- macvlan_handle_frame_hook = macvlan_handle_frame;
+ macvlan_handle_frame_hook = NULL;
unregister_netdevice_notifier(&macvlan_notifier_block);
return err;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.
2008-01-29 15:14 [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails Rami Rosen
@ 2008-01-29 15:19 ` Patrick McHardy
2008-02-01 0:56 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Patrick McHardy @ 2008-01-29 15:19 UTC (permalink / raw)
To: Rami Rosen; +Cc: netdev, David S. Miller
Rami Rosen wrote:
> Hi,
> In drivers/net/macvlan.c, when rtnl_link_register() fails
> in macvlan_init_module(), there is no point to set it (second time in this
> method) to macvlan_handle_frame; macvlan_init_module() will return a negative
> number, so instead this patch sets macvlan_handle_frame_hook to NULL.
Indeed, that seems to be a stupid cut-and-paste error. Thanks for
catching this.
Dave, please apply.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.
2008-01-29 15:19 ` Patrick McHardy
@ 2008-02-01 0:56 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2008-02-01 0:56 UTC (permalink / raw)
To: kaber; +Cc: ramirose, netdev
From: Patrick McHardy <kaber@trash.net>
Date: Tue, 29 Jan 2008 16:19:04 +0100
> Rami Rosen wrote:
> > Hi,
> > In drivers/net/macvlan.c, when rtnl_link_register() fails
> > in macvlan_init_module(), there is no point to set it (second time in this
> > method) to macvlan_handle_frame; macvlan_init_module() will return a negative
> > number, so instead this patch sets macvlan_handle_frame_hook to NULL.
>
>
> Indeed, that seems to be a stupid cut-and-paste error. Thanks for
> catching this.
>
> Dave, please apply.
Done.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-01 0:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-29 15:14 [PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails Rami Rosen
2008-01-29 15:19 ` Patrick McHardy
2008-02-01 0:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).