From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: sis190 build breakage
Date: Wed, 30 Jan 2008 03:22:51 -0500
Message-ID: <47A033DB.3070608@garzik.org>
References: <20080129215023.GA24152@stro.at> <20080129220310.GC15445@electric-eye.fr.zoreil.com> <20080130032838.GA17881@uranus.ravnborg.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Francois Romieu <romieu@fr.zoreil.com>,
	maximilian attems <max@stro.at>, netdev@vger.kernel.org
To: Sam Ravnborg <sam@ravnborg.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from srv5.dvmed.net ([207.36.208.214]:45486 "EHLO mail.dvmed.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754233AbYA3IW6 (ORCPT <rfc822;netdev@vger.kernel.org>);
	Wed, 30 Jan 2008 03:22:58 -0500
In-Reply-To: <20080130032838.GA17881@uranus.ravnborg.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Sam Ravnborg wrote:
> On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote:
>> maximilian attems <max@stro.at> :
>>>   CC [M]  drivers/net/sis190.o
>>>   drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict
>>>   make[5]: *** [drivers/net/sis190.o] Error 1
>>>
>>> gcc --version
>>> gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)
> 
> Looks like a bug where __initdata has been used
> for const data.
> Searching:
> static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev,
>                                                   struct net_device *dev)
> {
>         static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
>         struct sis190_private *tp = netdev_priv(dev);
>         struct pci_dev *isa_bridge;
>         u8 reg, tmp8;
> 
> Try to change this is __initconst and it should be fixed.

We have __initconst now?

Three cheers, and a beer, to whomever did that...

	Jeff