* sis190 build breakage @ 2008-01-29 21:50 maximilian attems 2008-01-29 22:03 ` Francois Romieu 0 siblings, 1 reply; 9+ messages in thread From: maximilian attems @ 2008-01-29 21:50 UTC (permalink / raw) To: netdev; +Cc: Francois Romieu CC [M] drivers/net/sis190.o drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[5]: *** [drivers/net/sis190.o] Error 1 gcc --version gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sis190 build breakage 2008-01-29 21:50 sis190 build breakage maximilian attems @ 2008-01-29 22:03 ` Francois Romieu 2008-01-29 22:27 ` maximilian attems 2008-01-30 3:28 ` Sam Ravnborg 0 siblings, 2 replies; 9+ messages in thread From: Francois Romieu @ 2008-01-29 22:03 UTC (permalink / raw) To: maximilian attems; +Cc: netdev maximilian attems <max@stro.at> : > CC [M] drivers/net/sis190.o > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict > make[5]: *** [drivers/net/sis190.o] Error 1 > > gcc --version > gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) Are you building latest git with DEBUG_SECTION_MISMATCH enabled by any misfortune ? -- Ueimor ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sis190 build breakage 2008-01-29 22:03 ` Francois Romieu @ 2008-01-29 22:27 ` maximilian attems 2008-01-29 22:27 ` Francois Romieu 2008-01-30 3:28 ` Sam Ravnborg 1 sibling, 1 reply; 9+ messages in thread From: maximilian attems @ 2008-01-29 22:27 UTC (permalink / raw) To: Francois Romieu; +Cc: netdev On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote: > maximilian attems <max@stro.at> : > > CC [M] drivers/net/sis190.o > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict > > make[5]: *** [drivers/net/sis190.o] Error 1 > > > > gcc --version > > gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) > > Are you building latest git with DEBUG_SECTION_MISMATCH enabled by any > misfortune ? yep latest git, but nope # CONFIG_DEBUG_SECTION_MISMATCH is not set probably i should to get interesting info. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sis190 build breakage 2008-01-29 22:27 ` maximilian attems @ 2008-01-29 22:27 ` Francois Romieu 2008-01-29 23:12 ` maximilian attems 0 siblings, 1 reply; 9+ messages in thread From: Francois Romieu @ 2008-01-29 22:27 UTC (permalink / raw) To: maximilian attems; +Cc: netdev maximilian attems <max@stro.at> : [...] > probably i should to get interesting info. Don't bother. $ less +/devinitdata Documentation/pci.txt [...] Tips on when/where to use the above attributes: o The module_init()/module_exit() functions (and all initialization functions called _only_ from these) should be marked __init/__exit. o Do not mark the struct pci_driver. o The ID table array should be marked __devinitdata. Could our documentation be wrong ? diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index b570402..2e9e88b 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -326,7 +326,7 @@ static const struct { { "SiS 191 PCI Gigabit Ethernet adapter" }, }; -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { +static struct pci_device_id sis190_pci_tbl[] = { { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 }, { 0, }, ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: sis190 build breakage 2008-01-29 22:27 ` Francois Romieu @ 2008-01-29 23:12 ` maximilian attems 2008-01-30 0:42 ` Randy Dunlap 0 siblings, 1 reply; 9+ messages in thread From: maximilian attems @ 2008-01-29 23:12 UTC (permalink / raw) To: Francois Romieu, Randy Dunlap; +Cc: netdev On Tue, Jan 29, 2008 at 11:27:48PM +0100, Francois Romieu wrote: > maximilian attems <max@stro.at> : > [...] > > probably i should to get interesting info. > > Don't bother. > > $ less +/devinitdata Documentation/pci.txt > [...] > Tips on when/where to use the above attributes: > o The module_init()/module_exit() functions (and all > initialization functions called _only_ from these) > should be marked __init/__exit. > > o Do not mark the struct pci_driver. > > o The ID table array should be marked __devinitdata. > > Could our documentation be wrong ? yep that was what i had in mind, so i was a bit baffled.. randy any insight? > > diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c > index b570402..2e9e88b 100644 > --- a/drivers/net/sis190.c > +++ b/drivers/net/sis190.c > @@ -326,7 +326,7 @@ static const struct { > { "SiS 191 PCI Gigabit Ethernet adapter" }, > }; > > -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { > +static struct pci_device_id sis190_pci_tbl[] = { > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 }, > { 0, }, thanks for quick fix. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sis190 build breakage 2008-01-29 23:12 ` maximilian attems @ 2008-01-30 0:42 ` Randy Dunlap 0 siblings, 0 replies; 9+ messages in thread From: Randy Dunlap @ 2008-01-30 0:42 UTC (permalink / raw) To: maximilian attems; +Cc: Francois Romieu, netdev, samr On Wed, 30 Jan 2008 00:12:23 +0100 maximilian attems wrote: > On Tue, Jan 29, 2008 at 11:27:48PM +0100, Francois Romieu wrote: > > maximilian attems <max@stro.at> : > > [...] > > > probably i should to get interesting info. > > > > Don't bother. > > > > $ less +/devinitdata Documentation/pci.txt > > [...] > > Tips on when/where to use the above attributes: > > o The module_init()/module_exit() functions (and all > > initialization functions called _only_ from these) > > should be marked __init/__exit. > > > > o Do not mark the struct pci_driver. > > > > o The ID table array should be marked __devinitdata. > > > > Could our documentation be wrong ? > > yep that was what i had in mind, so i was a bit baffled.. > > randy any insight? Hi, I can't reproduce the problem... :( I tend to expect something with Sam's new section mismatch detection. Maybe it's a lot better and found a real issue, but AFAIK this table can still be marked as __devinitdata. Sam cc-ed. > > > > diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c > > index b570402..2e9e88b 100644 > > --- a/drivers/net/sis190.c > > +++ b/drivers/net/sis190.c > > @@ -326,7 +326,7 @@ static const struct { > > { "SiS 191 PCI Gigabit Ethernet adapter" }, > > }; > > > > -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { > > +static struct pci_device_id sis190_pci_tbl[] = { > > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, > > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 }, > > { 0, }, > > thanks for quick fix. --- ~Randy ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sis190 build breakage 2008-01-29 22:03 ` Francois Romieu 2008-01-29 22:27 ` maximilian attems @ 2008-01-30 3:28 ` Sam Ravnborg 2008-01-30 8:22 ` Jeff Garzik 1 sibling, 1 reply; 9+ messages in thread From: Sam Ravnborg @ 2008-01-30 3:28 UTC (permalink / raw) To: Francois Romieu; +Cc: maximilian attems, netdev On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote: > maximilian attems <max@stro.at> : > > CC [M] drivers/net/sis190.o > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict > > make[5]: *** [drivers/net/sis190.o] Error 1 > > > > gcc --version > > gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) Looks like a bug where __initdata has been used for const data. Searching: static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev, struct net_device *dev) { static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 }; struct sis190_private *tp = netdev_priv(dev); struct pci_dev *isa_bridge; u8 reg, tmp8; Try to change this is __initconst and it should be fixed. Sam ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sis190 build breakage 2008-01-30 3:28 ` Sam Ravnborg @ 2008-01-30 8:22 ` Jeff Garzik 2008-01-30 9:13 ` Sam Ravnborg 0 siblings, 1 reply; 9+ messages in thread From: Jeff Garzik @ 2008-01-30 8:22 UTC (permalink / raw) To: Sam Ravnborg; +Cc: Francois Romieu, maximilian attems, netdev Sam Ravnborg wrote: > On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote: >> maximilian attems <max@stro.at> : >>> CC [M] drivers/net/sis190.o >>> drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict >>> make[5]: *** [drivers/net/sis190.o] Error 1 >>> >>> gcc --version >>> gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) > > Looks like a bug where __initdata has been used > for const data. > Searching: > static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev, > struct net_device *dev) > { > static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 }; > struct sis190_private *tp = netdev_priv(dev); > struct pci_dev *isa_bridge; > u8 reg, tmp8; > > Try to change this is __initconst and it should be fixed. We have __initconst now? Three cheers, and a beer, to whomever did that... Jeff ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sis190 build breakage 2008-01-30 8:22 ` Jeff Garzik @ 2008-01-30 9:13 ` Sam Ravnborg 0 siblings, 0 replies; 9+ messages in thread From: Sam Ravnborg @ 2008-01-30 9:13 UTC (permalink / raw) To: Jeff Garzik, Jan Beulich; +Cc: Francois Romieu, maximilian attems, netdev On Wed, Jan 30, 2008 at 03:22:51AM -0500, Jeff Garzik wrote: > Sam Ravnborg wrote: > >On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote: > >>maximilian attems <max@stro.at> : > >>> CC [M] drivers/net/sis190.o > >>> drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type > >>> conflict > >>> make[5]: *** [drivers/net/sis190.o] Error 1 > >>> > >>>gcc --version > >>>gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) > > > >Looks like a bug where __initdata has been used > >for const data. > >Searching: > >static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev, > > struct net_device *dev) > >{ > > static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 }; > > struct sis190_private *tp = netdev_priv(dev); > > struct pci_dev *isa_bridge; > > u8 reg, tmp8; > > > >Try to change this is __initconst and it should be fixed. > > We have __initconst now? > > Three cheers, and a beer, to whomever did that... I will hand over the cheers to Jan Beulich and drink the beer myself ;-) Sam ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-01-30 9:13 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-01-29 21:50 sis190 build breakage maximilian attems 2008-01-29 22:03 ` Francois Romieu 2008-01-29 22:27 ` maximilian attems 2008-01-29 22:27 ` Francois Romieu 2008-01-29 23:12 ` maximilian attems 2008-01-30 0:42 ` Randy Dunlap 2008-01-30 3:28 ` Sam Ravnborg 2008-01-30 8:22 ` Jeff Garzik 2008-01-30 9:13 ` Sam Ravnborg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).