From: Jeff Garzik <jeff@garzik.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Divy Le Ray <divy@chelsio.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] cxgb3: Remove incorrect __devinit annotations
Date: Wed, 30 Jan 2008 03:38:55 -0500 [thread overview]
Message-ID: <47A0379F.5090804@garzik.org> (raw)
In-Reply-To: <adak5lsdzew.fsf@cisco.com>
Roland Dreier wrote:
> When PCI error recovery was added to cxgb3, a function t3_io_slot_reset()
> was added. This function can call back into t3_prep_adapter() at any
> time, so t3_prep_adapter() can no longer be marked __devinit.
> This patch removes the __devinit annotation from t3_prep_adapter() and
> all the functions that it calls, which fixes
>
> WARNING: drivers/net/cxgb3/built-in.o(.text+0x2427): Section mismatch in reference from the function t3_io_slot_reset() to the function .devinit.text:t3_prep_adapter()
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
> ---
> drivers/net/cxgb3/mc5.c | 2 +-
> drivers/net/cxgb3/sge.c | 2 +-
> drivers/net/cxgb3/t3_hw.c | 22 ++++++++++------------
> 3 files changed, 12 insertions(+), 14 deletions(-)
applied
prev parent reply other threads:[~2008-01-30 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 22:45 [PATCH] cxgb3: Remove incorrect __devinit annotations Roland Dreier
2008-01-30 8:38 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A0379F.5090804@garzik.org \
--to=jeff@garzik.org \
--cc=divy@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).