From: Jeff Garzik <jgarzik@pobox.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: andrew@sanpeople.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 1/1 resend][arm/at91_ether.c] logical/bitand typo in function reset_phy() (inactive), drivers/net/arm/at91_ether.c
Date: Wed, 30 Jan 2008 03:39:03 -0500 [thread overview]
Message-ID: <47A037A7.4050102@pobox.com> (raw)
In-Reply-To: <479F8940.7030301@tiscali.nl>
Roel Kluin wrote:
> include/linux/mii.h:48:#define BMCR_RESET 0x8000
>
> The function reset_phy() is in "#if 0" inactivated code
> --
> Replace logical "&&" by bit "&" before BMCR_RESET
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/net/arm/at91_ether.c b/drivers/net/arm/at91_ether.c
> index 25b114a..0ae0d83 100644
> --- a/drivers/net/arm/at91_ether.c
> +++ b/drivers/net/arm/at91_ether.c
> @@ -384,7 +384,7 @@ static void reset_phy(struct net_device *dev)
> /* Wait until PHY reset is complete */
> do {
> read_phy(lp->phy_address, MII_BMCR, &bmcr);
> - } while (!(bmcr && BMCR_RESET));
> + } while (!(bmcr & BMCR_RESET));
>
> disable_mdi();
> spin_unlock_irq(&lp->lock);
applied
prev parent reply other threads:[~2008-01-30 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 20:14 [PATCH 1/1 resend][arm/at91_ether.c] logical/bitand typo in function reset_phy() (inactive), drivers/net/arm/at91_ether.c Roel Kluin
2008-01-30 8:39 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A037A7.4050102@pobox.com \
--to=jgarzik@pobox.com \
--cc=12o3l@tiscali.nl \
--cc=andrew@sanpeople.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).