From: Pavel Emelyanov <xemul@openvz.org>
To: Adrian Bunk <bunk@kernel.org>, "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Denis Lunev <den@openvz.org>
Subject: Re: Strange commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5
Date: Thu, 31 Jan 2008 13:27:39 +0300 [thread overview]
Message-ID: <47A1A29B.9000509@openvz.org> (raw)
In-Reply-To: <20080130175508.GC29368@does.not.exist>
Adrian Bunk wrote:
> Commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5
> ("[RAW]: Consolidate proc interface.") did not only change raw6_seq_ops
> (including adding 3 EXPORT_SYMBOL_GPL's to net/ipv4/raw.c for accessing
> functions from there), it also removed the only user of raw6_seq_ops...
The commit is not strange it is wrong :( Sorry David, when I checked
the according proc files, I saw that both files show sockets, but
overlooked that the raw6 one shows the ipv4 part of the ipv6 socket.
Denis noticed that this morning and has already prepared a fix.
So please, do not revert the commit, the fix will be at your mailbox today.
Thanks, Adrian.
> cu
> Adrian
>
prev parent reply other threads:[~2008-01-31 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 17:55 Strange commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5 Adrian Bunk
2008-01-31 10:27 ` Pavel Emelyanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A1A29B.9000509@openvz.org \
--to=xemul@openvz.org \
--cc=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).