From: Pavel Emelyanov <xemul@openvz.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] make struct ipv4_devconf static
Date: Thu, 31 Jan 2008 13:37:40 +0300 [thread overview]
Message-ID: <47A1A4F4.2050906@openvz.org> (raw)
In-Reply-To: <20080130200254.GC29368@does.not.exist>
Adrian Bunk wrote:
> struct ipv4_devconf can now become static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Pavel Emelyanov <xemul@openvz.org>
> ---
>
> include/linux/inetdevice.h | 2 --
> net/ipv4/devinet.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> 20262a3317069b1bdbf2b37f4002fa5322445914
> diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h
> index 8d9eaae..fc4e3db 100644
> --- a/include/linux/inetdevice.h
> +++ b/include/linux/inetdevice.h
> @@ -17,8 +17,6 @@ struct ipv4_devconf
> DECLARE_BITMAP(state, __NET_IPV4_CONF_MAX - 1);
> };
>
> -extern struct ipv4_devconf ipv4_devconf;
> -
> struct in_device
> {
> struct net_device *dev;
> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
> index 21f71bf..5ab5acc 100644
> --- a/net/ipv4/devinet.c
> +++ b/net/ipv4/devinet.c
> @@ -64,7 +64,7 @@
> #include <net/rtnetlink.h>
> #include <net/net_namespace.h>
>
> -struct ipv4_devconf ipv4_devconf = {
> +static struct ipv4_devconf ipv4_devconf = {
> .data = {
> [NET_IPV4_CONF_ACCEPT_REDIRECTS - 1] = 1,
> [NET_IPV4_CONF_SEND_REDIRECTS - 1] = 1,
>
>
prev parent reply other threads:[~2008-01-31 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 20:02 [2.6 patch] make struct ipv4_devconf static Adrian Bunk
2008-01-31 10:37 ` Pavel Emelyanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A1A4F4.2050906@openvz.org \
--to=xemul@openvz.org \
--cc=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).