From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index Date: Fri, 01 Feb 2008 12:52:38 -0500 Message-ID: <47A35C66.80008@pobox.com> References: <20080201150126.GB26545@localhost.localdomain> <72B60725-FB4A-42FA-832D-8FD5434B9042@kernel.crashing.org> <20080201173331.GA8020@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf8; format=flowed Content-Transfer-Encoding: 7bit Cc: Kumar Gala , Timur Tabi , Grant Likely , Li Yang , linuxppc-dev@ozlabs.org, linux-serial@vger.kernel.org, netdev@vger.kernel.org To: avorontsov@ru.mvista.com Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:40799 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752392AbYBARxG (ORCPT ); Fri, 1 Feb 2008 12:53:06 -0500 In-Reply-To: <20080201173331.GA8020@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: Anton Vorontsov wrote: > On Fri, Feb 01, 2008 at 09:32:38AM -0600, Kumar Gala wrote: >> On Feb 1, 2008, at 9:01 AM, Anton Vorontsov wrote: >> >>> It isn't used anywhere, so remove it. If we'll ever need something >>> like this, we'll use compatible property instead. >>> >>> Signed-off-by: Anton Vorontsov >>> --- >>> >>> Rebased on top of recent tree. >>> >>> Documentation/powerpc/booting-without-of.txt | 1 - >>> arch/powerpc/boot/dts/mpc832x_mds.dts | 3 --- >>> arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 -- >>> arch/powerpc/boot/dts/mpc836x_mds.dts | 2 -- >>> arch/powerpc/boot/dts/mpc8568mds.dts | 2 -- >>> 5 files changed, 0 insertions(+), 10 deletions(-) >>> >>> diff --git a/Documentation/powerpc/booting-without-of.txt b/ >>> Documentation/powerpc/booting-without-of.txt >>> index 410c847..dcf9758 100644 >>> --- a/Documentation/powerpc/booting-without-of.txt >>> +++ b/Documentation/powerpc/booting-without-of.txt >>> @@ -1675,7 +1675,6 @@ platforms are moved over to use the flattened- >>> device-tree model. >>> ucc@2000 { >>> device_type = "network"; >>> compatible = "ucc_geth"; >>> - model = "UCC"; >>> device-id = <1>; >> can we change device-id to cell-index? > > Sure. But let's do this in the separate patch? Because this change > actually touches the code in the two subsystems: net and serial. > > I hope everybody will agree to pass it through powerpc tree..? > > - - - - > From: Anton Vorontsov > Subject: [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index > > device-id is worse than cell-index. Probably cell-index isn't > good either, but device-id is worse anyway. > > Drivers are modified for backward compatibility's sake. > > Signed-off-by: Anton Vorontsov > --- > Documentation/powerpc/booting-without-of.txt | 4 ++-- > arch/powerpc/boot/dts/mpc832x_mds.dts | 4 +--- > arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 -- > arch/powerpc/boot/dts/mpc836x_mds.dts | 2 -- > arch/powerpc/boot/dts/mpc836x_rdk.dts | 12 ++++++------ > arch/powerpc/boot/dts/mpc8568mds.dts | 2 -- > drivers/net/ucc_geth.c | 8 +++++++- > drivers/net/ucc_geth_mii.c | 11 ++++++++--- > drivers/serial/ucc_uart.c | 16 ++++++++++++---- > 9 files changed, 36 insertions(+), 25 deletions(-) ACK drivers/net