* rtl8150: use default MTU of 1500
@ 2008-01-30 19:37 Lennert Buytenhek
2008-01-31 15:42 ` Petko Manolov
2008-02-01 18:41 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Lennert Buytenhek @ 2008-01-30 19:37 UTC (permalink / raw)
To: netdev, jgarzik; +Cc: Petko Manolov
The RTL8150 driver uses an MTU of 1540 by default, which causes a
bunch of problems -- it prevents booting from NFS root, for one.
Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Petko Manolov <petkan@nucleusys.com>
--- linux-2.6.24-git7.orig/drivers/net/usb/rtl8150.c 2008-01-24 23:58:37.000000000 +0100
+++ linux-2.6.24-git7/drivers/net/usb/rtl8150.c 2008-01-30 20:29:00.000000000 +0100
@@ -925,9 +925,8 @@
netdev->hard_start_xmit = rtl8150_start_xmit;
netdev->set_multicast_list = rtl8150_set_multicast;
netdev->set_mac_address = rtl8150_set_mac_address;
netdev->get_stats = rtl8150_netdev_stats;
- netdev->mtu = RTL8150_MTU;
SET_ETHTOOL_OPS(netdev, &ops);
dev->intr_interval = 100; /* 100ms */
if (!alloc_all_urbs(dev)) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: rtl8150: use default MTU of 1500
2008-01-30 19:37 rtl8150: use default MTU of 1500 Lennert Buytenhek
@ 2008-01-31 15:42 ` Petko Manolov
2008-01-31 16:05 ` Lennert Buytenhek
2008-02-01 18:41 ` Jeff Garzik
1 sibling, 1 reply; 4+ messages in thread
From: Petko Manolov @ 2008-01-31 15:42 UTC (permalink / raw)
To: Lennert Buytenhek; +Cc: netdev, jgarzik
On Wed, 30 Jan 2008, Lennert Buytenhek wrote:
> The RTL8150 driver uses an MTU of 1540 by default, which causes a
> bunch of problems -- it prevents booting from NFS root, for one.
Agreed, although it is a bit strange how this particular bug has sneaked
up for so long...
cheers,
Petko
> Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
> Cc: Petko Manolov <petkan@nucleusys.com>
>
> --- linux-2.6.24-git7.orig/drivers/net/usb/rtl8150.c 2008-01-24 23:58:37.000000000 +0100
> +++ linux-2.6.24-git7/drivers/net/usb/rtl8150.c 2008-01-30 20:29:00.000000000 +0100
> @@ -925,9 +925,8 @@
> netdev->hard_start_xmit = rtl8150_start_xmit;
> netdev->set_multicast_list = rtl8150_set_multicast;
> netdev->set_mac_address = rtl8150_set_mac_address;
> netdev->get_stats = rtl8150_netdev_stats;
> - netdev->mtu = RTL8150_MTU;
> SET_ETHTOOL_OPS(netdev, &ops);
> dev->intr_interval = 100; /* 100ms */
>
> if (!alloc_all_urbs(dev)) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: rtl8150: use default MTU of 1500
2008-01-31 15:42 ` Petko Manolov
@ 2008-01-31 16:05 ` Lennert Buytenhek
0 siblings, 0 replies; 4+ messages in thread
From: Lennert Buytenhek @ 2008-01-31 16:05 UTC (permalink / raw)
To: Petko Manolov; +Cc: netdev, jgarzik
On Thu, Jan 31, 2008 at 05:42:34PM +0200, Petko Manolov wrote:
> > The RTL8150 driver uses an MTU of 1540 by default, which causes a
> > bunch of problems -- it prevents booting from NFS root, for one.
>
> Agreed, although it is a bit strange how this particular bug has
> sneaked up for so long...
I posted this patch sometime in 2006, and you asked me a question
about it then (why we don't just set RTL8150_MTU to 1500 -- the
answer would be that RTL8150_MTU is used in a couple more places
in the driver, including for allocing skbuffs), but I failed to
follow up to that question at the time, which is why I assume it got
dropped.
I have been carrying the patch in my own tree since then, and only
noticed recently that the patch never made it upstream.
cheers,
Lennert
> >Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
> >Cc: Petko Manolov <petkan@nucleusys.com>
> >
> >--- linux-2.6.24-git7.orig/drivers/net/usb/rtl8150.c 2008-01-24
> >23:58:37.000000000 +0100
> >+++ linux-2.6.24-git7/drivers/net/usb/rtl8150.c 2008-01-30
> >20:29:00.000000000 +0100
> >@@ -925,9 +925,8 @@
> > netdev->hard_start_xmit = rtl8150_start_xmit;
> > netdev->set_multicast_list = rtl8150_set_multicast;
> > netdev->set_mac_address = rtl8150_set_mac_address;
> > netdev->get_stats = rtl8150_netdev_stats;
> >- netdev->mtu = RTL8150_MTU;
> > SET_ETHTOOL_OPS(netdev, &ops);
> > dev->intr_interval = 100; /* 100ms */
> >
> > if (!alloc_all_urbs(dev)) {
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: rtl8150: use default MTU of 1500
2008-01-30 19:37 rtl8150: use default MTU of 1500 Lennert Buytenhek
2008-01-31 15:42 ` Petko Manolov
@ 2008-02-01 18:41 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2008-02-01 18:41 UTC (permalink / raw)
To: Lennert Buytenhek; +Cc: netdev, Petko Manolov
Lennert Buytenhek wrote:
> The RTL8150 driver uses an MTU of 1540 by default, which causes a
> bunch of problems -- it prevents booting from NFS root, for one.
>
> Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
> Cc: Petko Manolov <petkan@nucleusys.com>
>
> --- linux-2.6.24-git7.orig/drivers/net/usb/rtl8150.c 2008-01-24 23:58:37.000000000 +0100
> +++ linux-2.6.24-git7/drivers/net/usb/rtl8150.c 2008-01-30 20:29:00.000000000 +0100
> @@ -925,9 +925,8 @@
> netdev->hard_start_xmit = rtl8150_start_xmit;
> netdev->set_multicast_list = rtl8150_set_multicast;
> netdev->set_mac_address = rtl8150_set_mac_address;
> netdev->get_stats = rtl8150_netdev_stats;
> - netdev->mtu = RTL8150_MTU;
> SET_ETHTOOL_OPS(netdev, &ops);
> dev->intr_interval = 100; /* 100ms */
>
> if (!alloc_all_urbs(dev)) {
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-02-01 18:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-30 19:37 rtl8150: use default MTU of 1500 Lennert Buytenhek
2008-01-31 15:42 ` Petko Manolov
2008-01-31 16:05 ` Lennert Buytenhek
2008-02-01 18:41 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).