* linux-2.6.24 compile error in drivers/net/b44.c @ 2008-02-02 1:50 Li Zefan 2008-02-02 4:51 ` Li Zefan 0 siblings, 1 reply; 5+ messages in thread From: Li Zefan @ 2008-02-02 1:50 UTC (permalink / raw) To: LKML; +Cc: netdev, David Miller drivers/net/b44.c: In function 'b44_remove_one': drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' make[2]: *** [drivers/net/b44.o] Error 1 make[1]: *** [drivers/net] Error 2 I think it is caused by: CONFIG_SSB_PCIHOST=n CONFIG_B44=y ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-2.6.24 compile error in drivers/net/b44.c 2008-02-02 1:50 linux-2.6.24 compile error in drivers/net/b44.c Li Zefan @ 2008-02-02 4:51 ` Li Zefan 2008-02-02 19:58 ` Miguel Botón 0 siblings, 1 reply; 5+ messages in thread From: Li Zefan @ 2008-02-02 4:51 UTC (permalink / raw) To: LKML; +Cc: netdev, David Miller, mboton, zambrano, linville Add CCs: CC: mboton@gmail.com CC: zambrano@broadcom.com CC: linville@tuxdriver.com Li Zefan wrote: > drivers/net/b44.c: In function 'b44_remove_one': > drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' > make[2]: *** [drivers/net/b44.o] Error 1 > make[1]: *** [drivers/net] Error 2 > > I think it is caused by: > > CONFIG_SSB_PCIHOST=n > CONFIG_B44=y > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-2.6.24 compile error in drivers/net/b44.c 2008-02-02 4:51 ` Li Zefan @ 2008-02-02 19:58 ` Miguel Botón 2008-02-03 1:53 ` Li Zefan 0 siblings, 1 reply; 5+ messages in thread From: Miguel Botón @ 2008-02-02 19:58 UTC (permalink / raw) To: Li Zefan; +Cc: LKML, netdev, David Miller, zambrano, linville Li Zefan wrote: > Add CCs: > > CC: mboton@gmail.com > CC: zambrano@broadcom.com > CC: linville@tuxdriver.com > > Li Zefan wrote: >> drivers/net/b44.c: In function 'b44_remove_one': >> drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' >> make[2]: *** [drivers/net/b44.o] Error 1 >> make[1]: *** [drivers/net] Error 2 >> >> I think it is caused by: >> >> CONFIG_SSB_PCIHOST=n >> CONFIG_B44=y >> > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ This patch should fix b44 errors when 'SSB_PCIHOST' is not enabled. Signed-off-by: Miguel Botón <mboton@gmail.com> diff --git a/drivers/net/b44.c b/drivers/net/b44.c index ea2a2b5..d081234 100644 --- a/drivers/net/b44.c +++ b/drivers/net/b44.c @@ -2228,7 +2228,9 @@ static void __devexit b44_remove_one(struct ssb_device *sdev) unregister_netdev(dev); ssb_bus_may_powerdown(sdev->bus); free_netdev(dev); +#ifdef B44_PCI ssb_pcihost_set_power_state(sdev, PCI_D3hot); +#endif ssb_set_drvdata(sdev, NULL); } @@ -2257,7 +2259,9 @@ static int b44_suspend(struct ssb_device *sdev, pm_message_t state) b44_setup_wol(bp); } +#ifdef B44_PCI ssb_pcihost_set_power_state(sdev, PCI_D3hot); +#endif return 0; } -- Miguel Botón ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: linux-2.6.24 compile error in drivers/net/b44.c 2008-02-02 19:58 ` Miguel Botón @ 2008-02-03 1:53 ` Li Zefan 2008-02-03 1:57 ` Li Zefan 0 siblings, 1 reply; 5+ messages in thread From: Li Zefan @ 2008-02-03 1:53 UTC (permalink / raw) To: Miguel Botón; +Cc: LKML, netdev, David Miller, zambrano, linville Miguel Botón 写道: > Li Zefan wrote: >> Add CCs: >> >> CC: mboton@gmail.com >> CC: zambrano@broadcom.com >> CC: linville@tuxdriver.com >> >> Li Zefan wrote: >>> drivers/net/b44.c: In function 'b44_remove_one': >>> drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' >>> make[2]: *** [drivers/net/b44.o] Error 1 >>> make[1]: *** [drivers/net] Error 2 >>> >>> I think it is caused by: >>> >>> CONFIG_SSB_PCIHOST=n >>> CONFIG_B44=y >>> >> > > This patch should fix b44 errors when 'SSB_PCIHOST' is not enabled. > I tried the patch, but it does't work, same compile error. :( If .config is needed, tell me and I will attach it. > Signed-off-by: Miguel Botón <mboton@gmail.com> > > diff --git a/drivers/net/b44.c b/drivers/net/b44.c > index ea2a2b5..d081234 100644 > --- a/drivers/net/b44.c > +++ b/drivers/net/b44.c > @@ -2228,7 +2228,9 @@ static void __devexit b44_remove_one(struct ssb_device *sdev) > unregister_netdev(dev); > ssb_bus_may_powerdown(sdev->bus); > free_netdev(dev); > +#ifdef B44_PCI > ssb_pcihost_set_power_state(sdev, PCI_D3hot); > +#endif > ssb_set_drvdata(sdev, NULL); > } > > @@ -2257,7 +2259,9 @@ static int b44_suspend(struct ssb_device *sdev, pm_message_t state) > b44_setup_wol(bp); > } > > +#ifdef B44_PCI > ssb_pcihost_set_power_state(sdev, PCI_D3hot); > +#endif > return 0; > } > > -- > Miguel Botón > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-2.6.24 compile error in drivers/net/b44.c 2008-02-03 1:53 ` Li Zefan @ 2008-02-03 1:57 ` Li Zefan 0 siblings, 0 replies; 5+ messages in thread From: Li Zefan @ 2008-02-03 1:57 UTC (permalink / raw) To: Miguel Botón; +Cc: LKML, netdev, David Miller, zambrano, linville Li Zefan wrote: > Miguel Botón 写道: >> Li Zefan wrote: >>> Add CCs: >>> >>> CC: mboton@gmail.com >>> CC: zambrano@broadcom.com >>> CC: linville@tuxdriver.com >>> >>> Li Zefan wrote: >>>> drivers/net/b44.c: In function 'b44_remove_one': >>>> drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' >>>> make[2]: *** [drivers/net/b44.o] Error 1 >>>> make[1]: *** [drivers/net] Error 2 >>>> >>>> I think it is caused by: >>>> >>>> CONFIG_SSB_PCIHOST=n >>>> CONFIG_B44=y >>>> >> This patch should fix b44 errors when 'SSB_PCIHOST' is not enabled. >> > > I tried the patch, but it does't work, same compile error. :( > > If .config is needed, tell me and I will attach it. > Sorry, I just made a mistake, actually the patch works. Thanks! >> Signed-off-by: Miguel Botón <mboton@gmail.com> >> >> diff --git a/drivers/net/b44.c b/drivers/net/b44.c >> index ea2a2b5..d081234 100644 >> --- a/drivers/net/b44.c >> +++ b/drivers/net/b44.c >> @@ -2228,7 +2228,9 @@ static void __devexit b44_remove_one(struct ssb_device *sdev) >> unregister_netdev(dev); >> ssb_bus_may_powerdown(sdev->bus); >> free_netdev(dev); >> +#ifdef B44_PCI >> ssb_pcihost_set_power_state(sdev, PCI_D3hot); >> +#endif >> ssb_set_drvdata(sdev, NULL); >> } >> >> @@ -2257,7 +2259,9 @@ static int b44_suspend(struct ssb_device *sdev, pm_message_t state) >> b44_setup_wol(bp); >> } >> >> +#ifdef B44_PCI >> ssb_pcihost_set_power_state(sdev, PCI_D3hot); >> +#endif >> return 0; >> } >> >> -- >> Miguel Botón >> >> > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-02-03 1:58 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-02-02 1:50 linux-2.6.24 compile error in drivers/net/b44.c Li Zefan 2008-02-02 4:51 ` Li Zefan 2008-02-02 19:58 ` Miguel Botón 2008-02-03 1:53 ` Li Zefan 2008-02-03 1:57 ` Li Zefan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).