From: Jeff Garzik <jgarzik@pobox.com>
To: Erik Mouw <mouw@nl.linux.org>
Cc: netdev@vger.kernel.org, "Waskiewicz Jr,
Peter P" <peter.p.waskiewicz.jr@intel.com>,
jamal <hadi@cyberus.ca>
Subject: Re: [PATCH] xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available
Date: Mon, 04 Feb 2008 17:31:50 -0500 [thread overview]
Message-ID: <47A79256.2040805@pobox.com> (raw)
In-Reply-To: <20080204212037.GB11417@gateway.home>
Erik Mouw wrote:
> On Mon, Feb 04, 2008 at 06:56:54PM +0100, Erik Mouw wrote:
>> Changes in other networking paths uncovered a bug in the xircom_cb
>> driver which made the kernel spew lots of the following error messages:
>>
>> BUG eth1 code -5 qlen 0
>>
>> It turned out that the driver returned -EIO when there was no
>> descriptor available for sending packets. It should return
>> NETDEV_TX_BUSY instead. This was discussed on the netdev list before,
>> see http://thread.gmane.org/gmane.linux.network/84603 .
>>
>> Signed-off-by: Erik Mouw <mouw@nl.linux.org>
>
> Forgot to tell: the patch is against 2.6.24 but should apply cleanly to
> the latest git kernel. The xircom_cb driver appears to be orphaned so
> I've send the patch to you.
Yep, that's the right thing to do...
Jeff
next prev parent reply other threads:[~2008-02-04 22:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 17:56 [PATCH] xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available Erik Mouw
2008-02-04 21:20 ` Erik Mouw
2008-02-04 22:31 ` Jeff Garzik [this message]
2008-02-05 18:33 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A79256.2040805@pobox.com \
--to=jgarzik@pobox.com \
--cc=hadi@cyberus.ca \
--cc=mouw@nl.linux.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).