From: Daniel Lezcano <dlezcano@fr.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [patch 14/14] replace __inline__ by inline in include/linux (net related)
Date: Wed, 06 Feb 2008 13:13:55 +0100 [thread overview]
Message-ID: <47A9A483.6060709@fr.ibm.com> (raw)
In-Reply-To: <20080206.032709.166069933.davem@davemloft.net>
David Miller wrote:
> From: Daniel Lezcano <dlezcano@fr.ibm.com>
> Date: Wed, 06 Feb 2008 11:39:27 +0100
>
>> YOSHIFUJI Hideaki / 吉藤英明 wrote:
>>> In article <20080206092300.701741592@mai.toulouse-stg.fr.ibm.com> (at Wed, 06 Feb 2008 10:14:19 +0100), Daniel Lezcano <dlezcano@fr.ibm.com> says:
>>>
>>>> replace __inline__ by inline in include/linux (net related)
>>>>
>>>> Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
>>>> ---
>>>> include/linux/atm.h | 4 ++--
>>>> include/linux/atmsap.h | 2 +-
>>>> include/linux/hdlc.h | 13 +++++++------
>>>> include/linux/inetdevice.h | 14 ++++++--------
>>>> include/linux/netlink.h | 5 +++--
>>>> include/linux/rtnetlink.h | 2 +-
>>>> 6 files changed, 20 insertions(+), 20 deletions(-)
>>> Please do this change within the #ifdef __KERNEL__ .. #endif only.
>> Oups ! I didn't thought about userspace program when modifying these
>> headers. Thanks for catching this.
>>
>> Hopefully, the patches can be applied separately. Is it possible to
>> discard this one ?
>
> What is the real problem though?
>
> Oh, c89 style C compilation will break with plain "inline"?
If a userspace program include one of these headers and compile with the
-ansi option, the keyword "inline" will be disabled and the compilation
will fail. For this reason when a header is exported, the __inline__
keyword should be used instead of "inline" to avoid such problem.
next prev parent reply other threads:[~2008-02-06 12:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 9:14 [patch 00/14] replace __inline__ by inline in net code Daniel Lezcano
2008-02-06 9:14 ` [patch 01/14] replace __inline__ by inline in net/ipv4 Daniel Lezcano
2008-02-06 9:14 ` [patch 02/14] replace __inline__ by inline in net/ipv6 Daniel Lezcano
2008-02-06 9:14 ` [patch 03/14] replace __inline__ by inline in net/appletalk Daniel Lezcano
2008-02-06 9:14 ` [patch 04/14] replace __inline__ by inline in net/atm Daniel Lezcano
2008-02-06 9:14 ` [patch 05/14] replace __inline__ by inline in net/core Daniel Lezcano
2008-02-06 9:14 ` [patch 06/14] replace __inline__ by inline in net/decnet Daniel Lezcano
2008-02-06 9:14 ` [patch 07/14] replace __inline__ by inline in net/sched Daniel Lezcano
2008-02-06 9:14 ` [patch 08/14] replace __inline__ by inline in net/x25 Daniel Lezcano
2008-02-06 9:14 ` [patch 09/14] replace __inline__ by inline in net/llc Daniel Lezcano
2008-02-06 9:14 ` [patch 10/14] replace __inline__ by inline in net/lapb Daniel Lezcano
2008-02-06 9:14 ` [patch 11/14] replace __inline__ by inline in net/key Daniel Lezcano
2008-02-06 9:14 ` [patch 12/14] replace __inline__ by inline in net/ipx Daniel Lezcano
2008-02-06 9:14 ` [patch 13/14] replace __inline__ by inline in include/net Daniel Lezcano
2008-02-06 9:14 ` [patch 14/14] replace __inline__ by inline in include/linux (net related) Daniel Lezcano
2008-02-06 10:31 ` YOSHIFUJI Hideaki / 吉藤英明
2008-02-06 10:39 ` Daniel Lezcano
2008-02-06 11:27 ` David Miller
2008-02-06 12:13 ` Daniel Lezcano [this message]
2008-02-06 11:25 ` David Miller
2008-02-06 11:29 ` [patch 00/14] replace __inline__ by inline in net code David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A9A483.6060709@fr.ibm.com \
--to=dlezcano@fr.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).