netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Claudio Lanconelli <lanconelli.claudio@eptar.com>
To: netdev@vger.kernel.org
Cc: David Brownell <david-b@pacbell.net>
Subject: Re: [patch 2.6.24-git] net/enc28j60: section fix
Date: Thu, 07 Feb 2008 12:13:17 +0100	[thread overview]
Message-ID: <47AAE7CD.9050801@eptar.com> (raw)
In-Reply-To: <200802062208.48838.david-b@pacbell.net>

David Brownell wrote:
> Minor bugfixes to the enc28j60 driver ... wrong section marking and
> indentation, and bogus use of spi_bus_type.  (Setting the bus type
> of a driver is a SPI framework responsibility.)
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>   

Acked-by: Claudio Lanconelli <lanconelli.claudio@eptar.com>
> ---
> Bonus patch.
>
>  drivers/net/enc28j60.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> --- a/drivers/net/enc28j60.c
> +++ b/drivers/net/enc28j60.c
> @@ -1555,7 +1555,7 @@ error_alloc:
>  	return ret;
>  }
>  
> -static int enc28j60_remove(struct spi_device *spi)
> +static int __devexit enc28j60_remove(struct spi_device *spi)
>  {
>  	struct enc28j60_net *priv = dev_get_drvdata(&spi->dev);
>  
> @@ -1572,9 +1572,8 @@ static int enc28j60_remove(struct spi_de
>  static struct spi_driver enc28j60_driver = {
>  	.driver = {
>  		   .name = DRV_NAME,
> -		   .bus = &spi_bus_type,
>  		   .owner = THIS_MODULE,
> -		   },
> +	 },
>  	.probe = enc28j60_probe,
>  	.remove = __devexit_p(enc28j60_remove),
>  };
>
>
>   


  reply	other threads:[~2008-02-07 11:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 19:01 [patch 2.6.24-git] net/enc28j60: oops fix, low power mode David Brownell
2008-02-06 17:11 ` Claudio Lanconelli
2008-02-06 17:33   ` [patch 2.6.24-git] net/enc28j60: oops fix David Brownell
2008-02-07 10:24     ` Claudio Lanconelli
2008-02-19 20:52       ` [RESEND/patch 2.6.25-rc2-git] " David Brownell
2008-03-05  1:17       ` [RE(*2)SEND/patch " David Brownell
2008-03-06  2:52         ` David Miller
2008-03-06  3:05           ` David Brownell
2008-02-06 18:19   ` [patch 2.6.24-git] net/enc28j60: low power mode David Brownell
2008-02-07 10:49     ` Claudio Lanconelli
2008-02-07  5:56   ` [patch 2.6.24-git] net/enc28j60: oops fix, " David Brownell
2008-02-07 10:53     ` Claudio Lanconelli
2008-02-10 17:54       ` David Brownell
2008-02-11 12:07         ` Claudio Lanconelli
2008-02-11 20:23           ` David Brownell
2008-02-14 10:28             ` Claudio Lanconelli
2008-02-07  6:08   ` [patch 2.6.24-git] net/enc28j60: " David Brownell
2008-02-07 11:21     ` Claudio Lanconelli
2008-02-10 17:45       ` David Brownell
2008-02-10 17:46       ` David Brownell
2008-02-07  6:08   ` [patch 2.6.24-git] net/enc28j60: section fix David Brownell
2008-02-07 11:13     ` Claudio Lanconelli [this message]
2008-02-19 20:54       ` [RESEND/patch 2.6.25-rc2-git] net/enc28j60: low power mode David Brownell
2008-02-19 20:56       ` [RESEND/patch 2.6.25-rc2-git] net/enc28j60: section fix David Brownell
2008-04-19  2:08       ` [RESEND/patch 2.6.25] " David Brownell
2008-04-19  2:08       ` [RESEND/patch 2.6.25] net/enc28j60: low power mode David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47AAE7CD.9050801@eptar.com \
    --to=lanconelli.claudio@eptar.com \
    --cc=david-b@pacbell.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).