[PATCH] [NETNS] Remove unused member (dst_net) of dst_ops.

[PATCH] [NETNS] Remove unused member (dst_net) of dst_ops.

[Rami Rosen]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

Hi,
  This patches removes dst_net member (a pointer to struct net)
  of dst_ops (/include/net/dst.h).
	
  Current network namespace implementation does not use it at all.

Denis - any comments ?
	

Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 284 bytes --]

diff --git a/include/net/dst.h b/include/net/dst.h
index e3ac7d0..ad06622 100644
--- a/include/net/dst.h
+++ b/include/net/dst.h
@@ -102,7 +102,6 @@ struct dst_ops
 
 	atomic_t		entries;
 	struct kmem_cache 		*kmem_cachep;
-	struct net              *dst_net;
 };
 
 #ifdef __KERNEL__

Re: [PATCH] [NETNS] Remove unused member (dst_net) of dst_ops.

[Denis V. Lunev]

This has been added by the Daniel Lezcano <dlezcano@fr.ibm.com> in the
commit d4fa26ff44e31c2636a985e3092e2cd55d8045de. It looks to me a
preparatory staff for IPv6 namespacing.

I think this is not needed in 2.6.25  but will be required in 2.6.26
very soon.

Regards,
	Den

On Fri, 2008-02-08 at 13:24 +0200, Rami Rosen wrote:
> Hi,
>   This patches removes dst_net member (a pointer to struct net)
>   of dst_ops (/include/net/dst.h).
> 	
>   Current network namespace implementation does not use it at all.
> 
> Denis - any comments ?
> 	
> 
> Regards,
> Rami Rosen
> 
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Re: [PATCH] [NETNS] Remove unused member (dst_net) of dst_ops.

[Daniel Lezcano]

Denis V. Lunev wrote:
> This has been added by the Daniel Lezcano <dlezcano@fr.ibm.com> in the
> commit d4fa26ff44e31c2636a985e3092e2cd55d8045de. It looks to me a
> preparatory staff for IPv6 namespacing.
> 
> I think this is not needed in 2.6.25  but will be required in 2.6.26
> very soon.

Yes, this is right, I posted this one just before sending ipv6 routing.
Unfortunately, I posted ipv6 routing per namespace when net-2.6.25 closed.

We can remove it for net-2.6 and I can repost it for net-2.6.26, if you 
want. Or we can just keep it ...

   -- Daniel

ps : thanks Denis :)

Re: [PATCH] [NETNS] Remove unused member (dst_net) of dst_ops.

[David Miller]

From: Daniel Lezcano <dlezcano@fr.ibm.com>
Date: Fri, 08 Feb 2008 13:33:49 +0100

> Denis V. Lunev wrote:
> > This has been added by the Daniel Lezcano <dlezcano@fr.ibm.com> in the
> > commit d4fa26ff44e31c2636a985e3092e2cd55d8045de. It looks to me a
> > preparatory staff for IPv6 namespacing.
> > 
> > I think this is not needed in 2.6.25  but will be required in 2.6.26
> > very soon.
> 
> Yes, this is right, I posted this one just before sending ipv6 routing.
> Unfortunately, I posted ipv6 routing per namespace when net-2.6.25 closed.
> 
> We can remove it for net-2.6 and I can repost it for net-2.6.26, if you 
> want. Or we can just keep it ...

Let's just keep it in there for now.