* [ofa-general] [PATCH 2.6.25] cxgb3: Handle ARP completions that mark neighbors stale. @ 2008-02-06 18:05 Steve Wise 2008-02-06 18:27 ` [ofa-general] " Divy Le Ray 2008-02-11 16:09 ` Jeff Garzik 0 siblings, 2 replies; 3+ messages in thread From: Steve Wise @ 2008-02-06 18:05 UTC (permalink / raw) To: jeff, divy; +Cc: netdev, linux-kernel, general cxgb3: Handle ARP completions that mark neighbors stale. When ARP completes due to a request rather than a reply the neighbor is marked NUD_STALE instead of reachable (see arp_process()). The handler for the resulting netevent needs to check also for NUD_STALE. Failure to use the arp entry can cause RDMA connection failures. Signed-off-by: Steve Wise <swise@opengridcomputing.com> --- drivers/net/cxgb3/l2t.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb3/l2t.c b/drivers/net/cxgb3/l2t.c index d660af7..d80bbdb 100644 --- a/drivers/net/cxgb3/l2t.c +++ b/drivers/net/cxgb3/l2t.c @@ -404,7 +404,7 @@ found: if (neigh->nud_state & NUD_FAILED) { arpq = e->arpq_head; e->arpq_head = e->arpq_tail = NULL; - } else if (neigh_is_connected(neigh)) + } else if (neigh->nud_state & (NUD_CONNECTED|NUD_STALE)) setup_l2e_send_pending(dev, NULL, e); } else { e->state = neigh_is_connected(neigh) ? ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [ofa-general] Re: [PATCH 2.6.25] cxgb3: Handle ARP completions that mark neighbors stale. 2008-02-06 18:05 [ofa-general] [PATCH 2.6.25] cxgb3: Handle ARP completions that mark neighbors stale Steve Wise @ 2008-02-06 18:27 ` Divy Le Ray 2008-02-11 16:09 ` Jeff Garzik 1 sibling, 0 replies; 3+ messages in thread From: Divy Le Ray @ 2008-02-06 18:27 UTC (permalink / raw) To: Steve Wise; +Cc: netdev, general, linux-kernel, jeff Steve Wise wrote: > cxgb3: Handle ARP completions that mark neighbors stale. > > When ARP completes due to a request rather than a reply the neighbor is > marked NUD_STALE instead of reachable (see arp_process()). The handler > for the resulting netevent needs to check also for NUD_STALE. > > Failure to use the arp entry can cause RDMA connection failures. > > Signed-off-by: Steve Wise <swise@opengridcomputing.com> > Acked-by: Divy Le Ray <divy@chelsio.com> Divy ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2.6.25] cxgb3: Handle ARP completions that mark neighbors stale. 2008-02-06 18:05 [ofa-general] [PATCH 2.6.25] cxgb3: Handle ARP completions that mark neighbors stale Steve Wise 2008-02-06 18:27 ` [ofa-general] " Divy Le Ray @ 2008-02-11 16:09 ` Jeff Garzik 1 sibling, 0 replies; 3+ messages in thread From: Jeff Garzik @ 2008-02-11 16:09 UTC (permalink / raw) To: Steve Wise; +Cc: divy, netdev, linux-kernel, general Steve Wise wrote: > cxgb3: Handle ARP completions that mark neighbors stale. > > When ARP completes due to a request rather than a reply the neighbor is > marked NUD_STALE instead of reachable (see arp_process()). The handler > for the resulting netevent needs to check also for NUD_STALE. > > Failure to use the arp entry can cause RDMA connection failures. > > Signed-off-by: Steve Wise <swise@opengridcomputing.com> applied ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-11 16:09 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-02-06 18:05 [ofa-general] [PATCH 2.6.25] cxgb3: Handle ARP completions that mark neighbors stale Steve Wise 2008-02-06 18:27 ` [ofa-general] " Divy Le Ray 2008-02-11 16:09 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).