From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 2/4] fib_trie: improve output format for /proc/net/fib_trie Date: Tue, 12 Feb 2008 19:23:59 -0800 Message-ID: <47B262CF.9040407@vyatta.com> References: <20080213005042.150212716@vyatta.com> <20080213005122.727447010@vyatta.com> <20080212182823.6f8a3a12.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Andrew Morton Return-path: Received: from mail.vyatta.com ([216.93.170.194]:42675 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752083AbYBMDYD (ORCPT ); Tue, 12 Feb 2008 22:24:03 -0500 In-Reply-To: <20080212182823.6f8a3a12.akpm@linux-foundation.org> Sender: netdev-owner@vger.kernel.org List-ID: Andrew Morton wrote: > On Tue, 12 Feb 2008 16:50:44 -0800 Stephen Hemminger wrote: > > >> Make output format prettier (more tree like). >> >> : >> --- 0.0.0.0/0 >> |--- 10.111.111.0/24 >> | +-- 10.111.111.0/32 link broadcast >> | |--- 10.111.111.254/31 >> | | +-- 10.111.111.254/32 host local >> | | +-- 10.111.111.255/32 link broadcast >> |--- 127.0.0.0/8 >> | |--- 127.0.0.0/31 >> | | +-- 127.0.0.0/32 link broadcast >> | | +-- 127.0.0.0/8 host local >> | | +-- 127.0.0.1/32 host local >> | +-- 127.255.255.255/32 link broadcast >> |--- 192.168.1.0/24 >> | |--- 192.168.1.0/28 >> | | +-- 192.168.1.0/32 link broadcast >> | | +-- 192.168.1.9/32 host local >> | +-- 192.168.1.255/32 link broadcast >>
: >> --- 0.0.0.0/0 >> |--- 0.0.0.0/4 >> | +-- 0.0.0.0/0 universe unicast >> | +-- 10.111.111.0/24 link unicast >> +-- 169.254.0.0/16 link unicast >> +-- 192.168.1.0/24 link unicast >> > > isn't that a non-back-compatible kernel ABI change? It might > break pre-existing parsers? > > Fib trie was always experimental and the output format was intended to be tree like but was broken. There are no known parsers of fib trie, and I think Vyatta will probably be the first distro to ship with it enabled. > aside: how lame are we to put pretty-printers in the kernel? > English-only ones, at that? Root cause: kernel developers still > don't have a sufficiently easy way of shipping userspace tools. Agreed, the structure of the trie doesn't come out via netlink (only the addresses).