* [PATCH] e1000e: Fix CRC stripping in hardware context bug
@ 2008-02-12 23:20 Auke Kok
2008-02-13 2:33 ` Andy Gospodarek
2008-02-15 15:53 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Auke Kok @ 2008-02-12 23:20 UTC (permalink / raw)
To: jeff; +Cc: e1000-devel, netdev, andy, johan.andersson
CRC stripping was only correctly enabled for packet split recieves
which is used when receiving jumbo frames. Correctly enable SECRC
also for normal buffer packet receives.
Tested by Andy Gospodarek and Johan Andersson, see bugzilla #9940.
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
---
drivers/net/e1000e/netdev.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index b9b0d32..ea4ecc3 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -1690,6 +1690,9 @@ static void e1000_setup_rctl(struct e1000_adapter *adapter)
else
rctl |= E1000_RCTL_LPE;
+ /* Enable hardware CRC frame stripping */
+ rctl |= E1000_RCTL_SECRC;
+
/* Setup buffer sizes */
rctl &= ~E1000_RCTL_SZ_4096;
rctl |= E1000_RCTL_BSEX;
@@ -1755,9 +1758,6 @@ static void e1000_setup_rctl(struct e1000_adapter *adapter)
/* Enable Packet split descriptors */
rctl |= E1000_RCTL_DTYP_PS;
-
- /* Enable hardware CRC frame stripping */
- rctl |= E1000_RCTL_SECRC;
psrctl |= adapter->rx_ps_bsize0 >>
E1000_PSRCTL_BSIZE0_SHIFT;
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] e1000e: Fix CRC stripping in hardware context bug
2008-02-12 23:20 [PATCH] e1000e: Fix CRC stripping in hardware context bug Auke Kok
@ 2008-02-13 2:33 ` Andy Gospodarek
2008-02-15 15:53 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Andy Gospodarek @ 2008-02-13 2:33 UTC (permalink / raw)
To: Auke Kok; +Cc: jeff, netdev, johan.andersson, andy, e1000-devel
On Tue, Feb 12, 2008 at 03:20:24PM -0800, Auke Kok wrote:
> CRC stripping was only correctly enabled for packet split recieves
> which is used when receiving jumbo frames. Correctly enable SECRC
> also for normal buffer packet receives.
>
> Tested by Andy Gospodarek and Johan Andersson, see bugzilla #9940.
>
This works well on my systems.
Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] e1000e: Fix CRC stripping in hardware context bug
2008-02-12 23:20 [PATCH] e1000e: Fix CRC stripping in hardware context bug Auke Kok
2008-02-13 2:33 ` Andy Gospodarek
@ 2008-02-15 15:53 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-02-15 15:53 UTC (permalink / raw)
To: Auke Kok; +Cc: netdev, johan.andersson, andy, e1000-devel
Auke Kok wrote:
> CRC stripping was only correctly enabled for packet split recieves
> which is used when receiving jumbo frames. Correctly enable SECRC
> also for normal buffer packet receives.
>
> Tested by Andy Gospodarek and Johan Andersson, see bugzilla #9940.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> ---
>
> drivers/net/e1000e/netdev.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-15 15:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-12 23:20 [PATCH] e1000e: Fix CRC stripping in hardware context bug Auke Kok
2008-02-13 2:33 ` Andy Gospodarek
2008-02-15 15:53 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).