From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: joe@perches.com, bruno@thinktube.com, netdev@vger.kernel.org,
jgarzik@pobox.com, linux-wireless@vger.kernel.org,
linville@tuxdriver.com
Subject: Re: [PATCH] net/8021q/vlan_dev.c - Use print_mac
Date: Tue, 19 Feb 2008 12:48:22 +0100 [thread overview]
Message-ID: <47BAC206.5070304@trash.net> (raw)
In-Reply-To: <20080218.165036.218650084.davem@davemloft.net>
David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Mon, 18 Feb 2008 16:43:05 -0800 (PST)
>
>> I think we can fix this easily by using __attribute_const_
>> on the print_mac() declaration. Let me play with that.
>
> Actually it seems the 'pure' attribute is more important
> here. Although it's not semantically a perfect match,
> what we need to tell the compiler is basically that:
>
> 1) the return value depends upon the inputs
> 2) if the input is not used, it's safe to avoid the call
>
> and 'pure' accomplishes that without any unwanted side-effects.
>
> I think this will not result in any unwanted over-optimization.
> Because if the inputs change in any way GCC has to emit the
> call.
>
> Any objections?
This seems fine to me, thanks Dave.
next prev parent reply other threads:[~2008-02-19 11:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 10:48 [PATCH] add macro for printing mac addresses Bruno Randolf
2008-02-15 10:58 ` David Miller
[not found] ` <20080215.025855.202184003.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-02-15 17:42 ` [PATCH] net/8021q/vlan_dev.c - Use print_mac Joe Perches
2008-02-18 7:35 ` David Miller
2008-02-18 15:19 ` Patrick McHardy
[not found] ` <47B9A20C.10304-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-02-18 18:31 ` Joe Perches
2008-02-18 21:31 ` Patrick McHardy
2008-02-18 20:55 ` David Miller
[not found] ` <20080218.125525.192686382.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-02-18 21:17 ` Patrick McHardy
[not found] ` <47B9F5E7.3020905-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-02-19 0:43 ` David Miller
[not found] ` <20080218.164305.67586867.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-02-19 0:50 ` David Miller
[not found] ` <20080218.165036.218650084.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-02-19 1:03 ` Joe Perches
2008-02-19 1:30 ` Philip Craig
2008-02-19 3:23 ` David Miller
2008-02-19 11:48 ` Patrick McHardy [this message]
2008-02-15 17:42 ` [PATCH 2/2] Remove MAC_FMT Joe Perches
2008-02-18 7:35 ` David Miller
2008-02-15 12:54 ` [PATCH] add macro for printing mac addresses Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BAC206.5070304@trash.net \
--to=kaber@trash.net \
--cc=bruno@thinktube.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).