* [PATCH][SCTP]: Pick up an orphaned sctp_sockets_allocated counter.
@ 2008-02-19 16:36 Pavel Emelyanov
2008-02-19 16:43 ` [Lksctp-developers] " Vlad Yasevich
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Emelyanov @ 2008-02-19 16:36 UTC (permalink / raw)
To: David Miller, Vlad Yasevich; +Cc: Linux Netdev List, lksctp-developers
This counter is currently write-only.
Drawing an analogy with the similar tcp counter, I think
that this one should be pointed by the sockets_allocated
members of sctp_prot and sctpv6_prot.
Or should it be instead removed at all?
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index d47d578..44797ad 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -6488,6 +6488,7 @@ struct proto sctp_prot = {
.memory_pressure = &sctp_memory_pressure,
.enter_memory_pressure = sctp_enter_memory_pressure,
.memory_allocated = &sctp_memory_allocated,
+ .sockets_allocated = &sctp_sockets_allocated,
REF_PROTO_INUSE(sctp)
};
@@ -6521,6 +6522,7 @@ struct proto sctpv6_prot = {
.memory_pressure = &sctp_memory_pressure,
.enter_memory_pressure = sctp_enter_memory_pressure,
.memory_allocated = &sctp_memory_allocated,
+ .sockets_allocated = &sctp_sockets_allocated,
REF_PROTO_INUSE(sctpv6)
};
#endif /* defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) */
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Lksctp-developers] [PATCH][SCTP]: Pick up an orphaned sctp_sockets_allocated counter.
2008-02-19 16:36 [PATCH][SCTP]: Pick up an orphaned sctp_sockets_allocated counter Pavel Emelyanov
@ 2008-02-19 16:43 ` Vlad Yasevich
2008-02-20 8:23 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Vlad Yasevich @ 2008-02-19 16:43 UTC (permalink / raw)
To: Pavel Emelyanov; +Cc: David Miller, Linux Netdev List, lksctp-developers
Pavel Emelyanov wrote:
> This counter is currently write-only.
>
> Drawing an analogy with the similar tcp counter, I think
> that this one should be pointed by the sockets_allocated
> members of sctp_prot and sctpv6_prot.
>
> Or should it be instead removed at all?
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Ack. Looks like it got missed. It should be added.
-vlad
>
> ---
>
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index d47d578..44797ad 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -6488,6 +6488,7 @@ struct proto sctp_prot = {
> .memory_pressure = &sctp_memory_pressure,
> .enter_memory_pressure = sctp_enter_memory_pressure,
> .memory_allocated = &sctp_memory_allocated,
> + .sockets_allocated = &sctp_sockets_allocated,
> REF_PROTO_INUSE(sctp)
> };
>
> @@ -6521,6 +6522,7 @@ struct proto sctpv6_prot = {
> .memory_pressure = &sctp_memory_pressure,
> .enter_memory_pressure = sctp_enter_memory_pressure,
> .memory_allocated = &sctp_memory_allocated,
> + .sockets_allocated = &sctp_sockets_allocated,
> REF_PROTO_INUSE(sctpv6)
> };
> #endif /* defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) */
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Lksctp-developers mailing list
> Lksctp-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lksctp-developers
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Lksctp-developers] [PATCH][SCTP]: Pick up an orphaned sctp_sockets_allocated counter.
2008-02-19 16:43 ` [Lksctp-developers] " Vlad Yasevich
@ 2008-02-20 8:23 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2008-02-20 8:23 UTC (permalink / raw)
To: vladislav.yasevich; +Cc: xemul, netdev, lksctp-developers
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Tue, 19 Feb 2008 11:43:44 -0500
> Pavel Emelyanov wrote:
> > This counter is currently write-only.
> >
> > Drawing an analogy with the similar tcp counter, I think
> > that this one should be pointed by the sockets_allocated
> > members of sctp_prot and sctpv6_prot.
> >
> > Or should it be instead removed at all?
> >
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>
> Ack. Looks like it got missed. It should be added.
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-20 8:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-19 16:36 [PATCH][SCTP]: Pick up an orphaned sctp_sockets_allocated counter Pavel Emelyanov
2008-02-19 16:43 ` [Lksctp-developers] " Vlad Yasevich
2008-02-20 8:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).