From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Pavel Emelyanov <xemul@openvz.org>
Cc: David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
lksctp-developers@lists.sourceforge.net
Subject: Re: [Lksctp-developers] [PATCH][SCTP]: Pick up an orphaned sctp_sockets_allocated counter.
Date: Tue, 19 Feb 2008 11:43:44 -0500 [thread overview]
Message-ID: <47BB0740.2070104@hp.com> (raw)
In-Reply-To: <47BB05AA.6090101@openvz.org>
Pavel Emelyanov wrote:
> This counter is currently write-only.
>
> Drawing an analogy with the similar tcp counter, I think
> that this one should be pointed by the sockets_allocated
> members of sctp_prot and sctpv6_prot.
>
> Or should it be instead removed at all?
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Ack. Looks like it got missed. It should be added.
-vlad
>
> ---
>
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index d47d578..44797ad 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -6488,6 +6488,7 @@ struct proto sctp_prot = {
> .memory_pressure = &sctp_memory_pressure,
> .enter_memory_pressure = sctp_enter_memory_pressure,
> .memory_allocated = &sctp_memory_allocated,
> + .sockets_allocated = &sctp_sockets_allocated,
> REF_PROTO_INUSE(sctp)
> };
>
> @@ -6521,6 +6522,7 @@ struct proto sctpv6_prot = {
> .memory_pressure = &sctp_memory_pressure,
> .enter_memory_pressure = sctp_enter_memory_pressure,
> .memory_allocated = &sctp_memory_allocated,
> + .sockets_allocated = &sctp_sockets_allocated,
> REF_PROTO_INUSE(sctpv6)
> };
> #endif /* defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) */
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Lksctp-developers mailing list
> Lksctp-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lksctp-developers
>
next prev parent reply other threads:[~2008-02-19 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 16:36 [PATCH][SCTP]: Pick up an orphaned sctp_sockets_allocated counter Pavel Emelyanov
2008-02-19 16:43 ` Vlad Yasevich [this message]
2008-02-20 8:23 ` [Lksctp-developers] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BB0740.2070104@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).