From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonas Bonn Subject: Re: pci_device_id cleanups Date: Wed, 20 Feb 2008 14:27:19 +0100 Message-ID: <47BC2AB7.4040402@southpole.se> References: <1203512031-14318-1-git-send-email-jonas@southpole.se> <20080220131704.GB18790@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, greg@kroah.com To: Sam Ravnborg Return-path: Received: from mail.southpole.se ([193.12.106.18]:43210 "EHLO mail.southpole.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbYBTN1V (ORCPT ); Wed, 20 Feb 2008 08:27:21 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.southpole.se (Postfix) with SMTP id 85FA64ED0FE for ; Wed, 20 Feb 2008 14:27:20 +0100 (CET) In-Reply-To: <20080220131704.GB18790@uranus.ravnborg.org> Sender: netdev-owner@vger.kernel.org List-ID: Sam Ravnborg wrote: > On Wed, Feb 20, 2008 at 01:53:36PM +0100, Jonas Bonn wrote: >> The PCI_DEVICE_TABLE patch I sent earlier doesn't necessarily make >> much sense by itself... here is a set of patches that apply >> this macro, in turn moving a lot of this data into __devinitconst >> which is discardable in certain situations. >> Hopefully the benefit of this approach is a bit clearer now. > [shorter lines please..] Sorry... > > Can you please confirm that this does not break powerpc (64 bit) > as they have troubles with the constification.. I do not have access to any PowerPC machine... Olof Johansson built the tree I posted earlier on PowerPC; there's nothing really new here except the wrapping of the definition in a macro. But of course, it would great if someone could confirm this... > > Sam >