netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonas Bonn <jonas@southpole.se>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	greg@kroah.com, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: PowerPC toolchain for x86 [Was: pci_device_id cleanups]
Date: Wed, 20 Feb 2008 15:03:30 +0100	[thread overview]
Message-ID: <47BC3332.7090705@southpole.se> (raw)
In-Reply-To: <20080220135533.GA19024@uranus.ravnborg.org>



Sam Ravnborg wrote:
> On Wed, Feb 20, 2008 at 02:27:19PM +0100, Jonas Bonn wrote:
>> Sam Ravnborg wrote:
>>> On Wed, Feb 20, 2008 at 01:53:36PM +0100, Jonas Bonn wrote:
>>>> The PCI_DEVICE_TABLE patch I sent earlier doesn't necessarily make
>>>> much sense by itself... here is a set of patches that apply
>>>> this macro, in turn moving a lot of this data into __devinitconst
>>>> which is discardable in certain situations.
>>>> Hopefully the benefit of this approach is a bit clearer now.
>>> [shorter lines please..]
>> Sorry...
>>
>>> Can you please confirm that this does not break powerpc (64 bit)
>>> as they have troubles with the constification..
>> I do not have access to any PowerPC machine... Olof Johansson built the 
>> tree I posted earlier on PowerPC; there's nothing really new here except 
>> the wrapping of the definition in a macro.
> And you added const and a specific section.

No... once the macro is expanded the code is exactly the same as that 
which built cleanly on powerpc previously (which Olof, built, I mean)... 
nothing new here.

> Exactly what could break on PowerPC.
> 
> To do the build break check is easy.
> Google for "crosstool" and build your own powerpc toolchain.
> 

Thanks... I'll throw together a cross compiler and see what I can do.

/Jonas

> Andrew has something precompiled somewhere but I lost the link.
> 
> 
> 	Sam
> 


      reply	other threads:[~2008-02-20 14:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 12:53 pci_device_id cleanups Jonas Bonn
2008-02-20 12:53 ` [PATCH] Add PCI_DEVICE_TABLE macro Jonas Bonn
2008-02-20 12:53   ` [PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst Jonas Bonn
2008-02-20 12:53     ` Jonas Bonn
2008-02-20 12:53       ` Jonas Bonn
2008-02-20 12:53         ` Jonas Bonn
2008-02-20 12:53           ` Jonas Bonn
2008-02-20 12:53             ` Jonas Bonn
2008-02-20 12:53               ` Jonas Bonn
2008-02-20 12:53                 ` Jonas Bonn
2008-02-20 12:53                   ` Jonas Bonn
2008-02-20 12:53                     ` Jonas Bonn
2008-02-20 12:53                       ` Jonas Bonn
2008-02-20 12:53                         ` Jonas Bonn
2008-02-20 12:53                           ` Jonas Bonn
2008-02-20 12:53                             ` Jonas Bonn
2008-02-20 13:17 ` pci_device_id cleanups Sam Ravnborg
2008-02-20 13:27   ` Jonas Bonn
2008-02-20 13:55     ` PowerPC toolchain for x86 [Was: pci_device_id cleanups] Sam Ravnborg
2008-02-20 14:03       ` Jonas Bonn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BC3332.7090705@southpole.se \
    --to=jonas@southpole.se \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).