From: Tony Battersby <tonyb@cybernetics.com>
To: Matt Carlson <mcarlson@broadcom.com>
Cc: Michael Chan <mchan@broadcom.com>,
David Miller <davem@davemloft.net>,
herbert@gondor.apana.org.au, netdev <netdev@vger.kernel.org>,
gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: TG3 network data corruption regression 2.6.24/2.6.23.4
Date: Wed, 20 Feb 2008 18:04:09 -0500 [thread overview]
Message-ID: <47BCB1E9.8020102@cybernetics.com> (raw)
In-Reply-To: <20080220013824.GA5416@localdomain>
The following patch fixes the problem for me. Do we want to accept this
patch and call it a day or continue investigating the source of the problem?
Patch applies to 2.6.24.2, but doesn't apply to 2.6.25-rc. If everyone
agrees that this is the right solution, I will resubmit with a proper
subject line and description.
Tony
--- linux-2.6.24.2/include/net/sock.h.orig 2008-02-20 17:19:20.000000000 -0500
+++ linux-2.6.24.2/include/net/sock.h 2008-02-20 17:25:55.000000000 -0500
@@ -1236,8 +1236,10 @@ static inline struct sk_buff *sk_stream_
{
struct sk_buff *skb;
- /* The TCP header must be at least 32-bit aligned. */
- size = ALIGN(size, 4);
+ /* The TCP header must be at least 32-bit aligned, but some chipsets
+ * such as Broadcom BCM5701 require at least 16-byte alignment.
+ */
+ size = ALIGN(size, 16);
skb = alloc_skb_fclone(size + sk->sk_prot->max_header, gfp);
if (skb) {
next prev parent reply other threads:[~2008-02-20 23:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 22:41 TG3 network data corruption regression 2.6.24/2.6.23.4 Tony Battersby
2008-02-19 0:32 ` Michael Chan
2008-02-19 0:35 ` David Miller
2008-02-19 1:04 ` Michael Chan
2008-02-19 16:16 ` Tony Battersby
2008-02-19 19:11 ` Michael Chan
2008-02-19 19:26 ` Tony Battersby
2008-02-19 22:14 ` Tony Battersby
2008-02-19 23:52 ` Michael Chan
2008-02-20 15:01 ` Tony Battersby
2008-02-20 1:38 ` Matt Carlson
2008-02-20 16:13 ` Tony Battersby
2008-02-20 21:29 ` Tony Battersby
2008-02-20 23:04 ` Tony Battersby [this message]
2008-02-20 23:08 ` David Miller
2008-02-20 23:17 ` Michael Chan
2008-02-20 3:45 ` Herbert Xu
2008-02-20 15:18 ` Tony Battersby
2008-04-15 0:12 ` Matt Carlson
2008-04-15 15:39 ` Tony Battersby
2008-04-16 3:31 ` David Miller
2008-04-16 15:40 ` Michael Chan
2008-04-16 20:17 ` Matt Carlson
2008-04-16 21:00 ` Tony Battersby
2008-04-18 6:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BCB1E9.8020102@cybernetics.com \
--to=tonyb@cybernetics.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).