From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: Ramkrishna.Vepa@neterion.com, Sreenivasa.Honnur@neterion.com,
netdev@vger.kernel.org, jeff@garzik.org, support@neterion.com
Subject: Re: [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports
Date: Thu, 21 Feb 2008 00:21:48 +0100 [thread overview]
Message-ID: <47BCB60C.3040409@trash.net> (raw)
In-Reply-To: <20080220.151834.133850272.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Thu, 21 Feb 2008 00:15:13 +0100
>
>
>> I missed those discussions, but this has already been agreed on,
>> fine by me. It would still be preferable to use queue_mapping
>> instead of priority IMO, even if its activated by a module
>> parameter, since that leaves the option to use classifiers.
>>
>
> I think the driver should compute the value in it's transmit
> routine and keep the value local. It shouldn't be setting
> skb->foo values at all, they don't belong to the driver
> and this could confuse other code.
>
Yes, I didn't meant it should set anything, but on of the options
this patch introduces is to _use_ skb->priority for classification,
so the classification is already external, in which case it might
as well offer the full flexibility (as one option) to use qdisc
classifiers.
next prev parent reply other threads:[~2008-02-20 23:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 22:07 [PATCH 2.6.25 2/4]S2io: Multiqueue network device support - FIFO selection based on L4 ports Sreenivasa Honnur
2008-02-20 22:16 ` Patrick McHardy
2008-02-20 22:57 ` Ramkrishna Vepa
2008-02-20 23:08 ` Patrick McHardy
2008-02-20 23:12 ` David Miller
2008-02-20 23:15 ` Patrick McHardy
2008-02-20 23:18 ` David Miller
2008-02-20 23:21 ` Patrick McHardy [this message]
2008-02-20 23:49 ` Ramkrishna Vepa
2008-02-24 5:01 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BCB60C.3040409@trash.net \
--to=kaber@trash.net \
--cc=Ramkrishna.Vepa@neterion.com \
--cc=Sreenivasa.Honnur@neterion.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=support@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).