From: Patrick McHardy <kaber@trash.net>
To: David Woodhouse <dwmw2@infradead.org>
Cc: netdev@vger.kernel.org, Jan Engelhardt <jengelh@computergmbh.de>,
"David S. Miller" <davem@davemloft.net>,
varekova@redhat.com
Subject: Re: [NETFILTER]: Introduce nf_inet_address
Date: Thu, 21 Feb 2008 13:00:29 +0100 [thread overview]
Message-ID: <47BD67DD.6020404@trash.net> (raw)
In-Reply-To: <1203594725.15409.48.camel@shinybook.infradead.org>
David Woodhouse wrote:
> On Tue, 2008-02-19 at 15:45 +0100, Patrick McHardy wrote:
>> That would break iptables compilation, which already includes
>> linux/in.h in some files. I guess the best fix for now is to
>> include netinet/in.h in busybox and long-term clean this up
>> properly.
>
> Yeah, that makes sense.
>
> Can we push the change to __u32 (or uint32_t) for 2.6.24? Or is there
> something obvious we should be doing in busybox which we aren't? I don't
> quite understand why this u_int32_t crap doesn't work at _all_ when it
> evidently used to at least in some environments.
I already sent it to Dave for 2.6.25 (I assume that what you meant,
it was introduced after 2.6.24), its currently sitting in net-2.6
and should hit Linus' tree next time he pulls from Dave.
next prev parent reply other threads:[~2008-02-21 12:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200801291316.m0TDGivY024953@hera.kernel.org>
2008-02-19 13:49 ` [NETFILTER]: Introduce nf_inet_address David Woodhouse
2008-02-19 14:01 ` Patrick McHardy
2008-02-19 14:30 ` David Woodhouse
2008-02-19 14:45 ` Patrick McHardy
2008-02-20 10:24 ` Jan Engelhardt
2008-02-21 11:52 ` David Woodhouse
2008-02-21 12:00 ` Patrick McHardy [this message]
2008-02-21 12:19 ` David Woodhouse
2008-02-22 7:52 ` David Woodhouse
2008-02-22 8:01 ` David Woodhouse
2008-02-22 14:59 ` Patrick McHardy
2008-02-22 14:58 ` Patrick McHardy
2008-02-22 15:38 ` Pablo Neira Ayuso
2008-02-22 15:44 ` Patrick McHardy
2008-02-22 16:03 ` Jan Engelhardt
2008-02-22 16:08 ` Pablo Neira Ayuso
2008-02-22 16:12 ` Patrick McHardy
2008-02-22 22:37 ` David Woodhouse
2008-02-25 12:12 ` Patrick McHardy
2008-02-25 12:17 ` David Woodhouse
2008-02-25 12:20 ` Patrick McHardy
2008-02-25 12:21 ` David Woodhouse
2008-02-25 12:23 ` Patrick McHardy
2008-02-25 12:29 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BD67DD.6020404@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=jengelh@computergmbh.de \
--cc=netdev@vger.kernel.org \
--cc=varekova@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).