netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Pavel Emelyanov <xemul@openvz.org>
Cc: David Miller <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>,
	devel@openvz.org
Subject: Re: [PATCH] Don't limit the number of tunnels with generic name explicitly.
Date: Thu, 21 Feb 2008 13:45:15 +0100	[thread overview]
Message-ID: <47BD725B.4050408@trash.net> (raw)
In-Reply-To: <47BD70B8.3030507@openvz.org>

Pavel Emelyanov wrote:
> Patrick McHardy wrote:
>> Pavel Emelyanov wrote:
>>> Patrick McHardy wrote:
>>>
>>>> It would be nicer to replace the entire hand-made name
>>>> allocation to remove the 100 device limit.
>>>>
>>> Actually, I thought the same, but fixing % in names looks like a 
>>> BUG-fix for 2.6.25, while removing the hand-made name allocation 
>>> looks like an enhancement for 2.6.26. No?
>>
>> Well, its so closely related that I guess it would still look
>> like a bugfix :) But changing this in 2.6.26 is also fine of
>> course, your patch just reminded me since I wanted to change
>> this for a long time and repeatedly forgot about it again.
> 
> Ok, point taken ;) Here's the 2nd patch that does so. If David 
> decides it can go to 2.6.25, that would be good, otherwise this 
> patch will fit the 2.6.26 as well.
> 
> Changelog:
> 
> Use the added dev_alloc_name() call to create tunnel device name,
> rather than iterate in a hand-made loop with an artificial limit.
> 
> Thanks Patrick for noticing this.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>


Looks good to me, thanks.

  reply	other threads:[~2008-02-21 12:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 12:05 [PATCH] Don't create tunnels with '%' in name Pavel Emelyanov
2008-02-21 12:10 ` Patrick McHardy
2008-02-21 12:17   ` Pavel Emelyanov
2008-02-21 12:22     ` Patrick McHardy
2008-02-21 12:38       ` [PATCH] Don't limit the number of tunnels with generic name explicitly Pavel Emelyanov
2008-02-21 12:45         ` Patrick McHardy [this message]
2008-02-24  4:20         ` David Miller
2008-02-26  7:47           ` Pavel Emelyanov
2008-02-26 21:31             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BD725B.4050408@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=devel@openvz.org \
    --cc=netdev@vger.kernel.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).