From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] Don't limit the number of tunnels with generic name explicitly. Date: Thu, 21 Feb 2008 13:45:15 +0100 Message-ID: <47BD725B.4050408@trash.net> References: <47BD6907.7050303@openvz.org> <47BD6A28.1030007@trash.net> <47BD6BD7.1060200@openvz.org> <47BD6CE9.7000908@trash.net> <47BD70B8.3030507@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , Linux Netdev List , devel@openvz.org To: Pavel Emelyanov Return-path: Received: from viefep31-int.chello.at ([62.179.121.49]:61020 "EHLO viefep31-int.chello.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbYBUMpj (ORCPT ); Thu, 21 Feb 2008 07:45:39 -0500 In-Reply-To: <47BD70B8.3030507@openvz.org> Sender: netdev-owner@vger.kernel.org List-ID: Pavel Emelyanov wrote: > Patrick McHardy wrote: >> Pavel Emelyanov wrote: >>> Patrick McHardy wrote: >>> >>>> It would be nicer to replace the entire hand-made name >>>> allocation to remove the 100 device limit. >>>> >>> Actually, I thought the same, but fixing % in names looks like a >>> BUG-fix for 2.6.25, while removing the hand-made name allocation >>> looks like an enhancement for 2.6.26. No? >> >> Well, its so closely related that I guess it would still look >> like a bugfix :) But changing this in 2.6.26 is also fine of >> course, your patch just reminded me since I wanted to change >> this for a long time and repeatedly forgot about it again. > > Ok, point taken ;) Here's the 2nd patch that does so. If David > decides it can go to 2.6.25, that would be good, otherwise this > patch will fit the 2.6.26 as well. > > Changelog: > > Use the added dev_alloc_name() call to create tunnel device name, > rather than iterate in a hand-made loop with an artificial limit. > > Thanks Patrick for noticing this. > > Signed-off-by: Pavel Emelyanov Looks good to me, thanks.