From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Tilman Schmidt <tilman@imap.cc>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: 2.6.25-rc2-mm1 - several bugs and a crash
Date: Thu, 21 Feb 2008 17:34:56 +0100 [thread overview]
Message-ID: <47BDA830.1000608@trash.net> (raw)
In-Reply-To: <20080221083248.5b76b496@extreme>
Stephen Hemminger wrote:
> On Thu, 21 Feb 2008 12:28:50 +0100
> Patrick McHardy <kaber@trash.net> wrote:
>
>
>
>> diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
>> index 327e847..b77eb56 100644
>> --- a/net/netfilter/nf_conntrack_core.c
>> +++ b/net/netfilter/nf_conntrack_core.c
>> @@ -256,13 +256,19 @@ __nf_conntrack_find(const struct nf_conntrack_tuple *tuple)
>> struct hlist_node *n;
>> unsigned int hash = hash_conntrack(tuple);
>>
>> + /* Disable BHs the entire time since we normally need to disable them
>> + * at least once for the stats anyway.
>> + */
>> + local_bh_disable();
>>
>
> Use rcu_read_lock instead. local_bh_disable() won't work with some of the other forms
> of RCU alternatives.
>
The caller already calls rcu_read_lock(). This is for the per-cpu
statistics.
next prev parent reply other threads:[~2008-02-21 16:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080216002522.9c4bd0fb.akpm@linux-foundation.org>
2008-02-20 21:14 ` 2.6.25-rc2-mm1 - several bugs and a crash Tilman Schmidt
2008-02-20 21:50 ` Patrick McHardy
2008-02-21 11:28 ` Patrick McHardy
2008-02-21 16:32 ` Stephen Hemminger
2008-02-21 16:34 ` Patrick McHardy [this message]
2008-02-22 0:40 ` Tilman Schmidt
2008-02-22 0:52 ` Tilman Schmidt
2008-02-22 17:09 ` Paul E. McKenney
2008-02-25 8:54 ` Tilman Schmidt
2008-02-27 16:37 ` nf_conntrack fix smp_processor_id() in preemptible code (was: 2.6.25-rc2-mm1 - several bugs and a crash) Tilman Schmidt
2008-02-27 16:47 ` nf_conntrack fix smp_processor_id() in preemptible code Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BDA830.1000608@trash.net \
--to=kaber@trash.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).