From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: fix LED management
Date: Sun, 24 Feb 2008 00:11:41 -0500 [thread overview]
Message-ID: <47C0FC8D.7040202@pobox.com> (raw)
In-Reply-To: <20080222160033.79649405@extreme>
Stephen Hemminger wrote:
> Fix problems in LED management, so ethtool -p works correctly on Yukon-EC
> and other chips. The driver was incorrectly setting the PHY LED overide bits.
> Moral: read the spec sheet, not the vendor driver.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
> ---
> drivers/net/sky2.c | 99 +++++++++++++++++------------------------------------
> drivers/net/sky2.h | 21 +++++------
> 2 files changed, 44 insertions(+), 76 deletions(-)
applied
prev parent reply other threads:[~2008-02-24 5:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-23 0:00 [PATCH] sky2: fix LED management Stephen Hemminger
2008-02-24 5:11 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C0FC8D.7040202@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).