From: Jeff Garzik <jeff@garzik.org>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH 7/7] e1000e: remove unused read value in ASPM disable code.
Date: Sun, 24 Feb 2008 00:11:57 -0500 [thread overview]
Message-ID: <47C0FC9D.1090207@garzik.org> (raw)
In-Reply-To: <20080221231113.5595.11336.stgit@localhost.localdomain>
Auke Kok wrote:
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> ---
>
> drivers/net/e1000e/netdev.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
> index 7824bc2..fc5c63f 100644
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -3490,7 +3490,6 @@ static int e1000_suspend(struct pci_dev *pdev, pm_message_t state)
> static void e1000e_disable_l1aspm(struct pci_dev *pdev)
> {
> int pos;
> - u32 cap;
> u16 val;
>
> /*
> @@ -3505,7 +3504,6 @@ static void e1000e_disable_l1aspm(struct pci_dev *pdev)
> * active.
> */
> pos = pci_find_capability(pdev, PCI_CAP_ID_EXP);
> - pci_read_config_dword(pdev, pos + PCI_EXP_LNKCAP, &cap);
> pci_read_config_word(pdev, pos + PCI_EXP_LNKCTL, &val);
> if (val & 0x2) {
applied 1-7
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2008-02-24 5:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 23:10 [PATCH 1/7] ixgb: add RNBC counter - no buffer count - to ethtool stats Auke Kok
2008-02-21 23:10 ` [PATCH 2/7] e1000e: 82573 can use eerd method to read eeprom Auke Kok
2008-02-21 23:10 ` [PATCH 3/7] e1000e: fix link up message to show ethX: Auke Kok
2008-02-21 23:10 ` [PATCH 4/7] e1000e: fix flow control when using ethtool overrides Auke Kok
2008-02-21 23:11 ` [PATCH 5/7] e1000e: fix flow control denial of service possibility Auke Kok
2008-02-21 23:11 ` [PATCH 6/7] e1000e: fix spelling errors in comments Auke Kok
2008-02-21 23:11 ` [PATCH 7/7] e1000e: remove unused read value in ASPM disable code Auke Kok
2008-02-24 5:11 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C0FC9D.1090207@garzik.org \
--to=jeff@garzik.org \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).