From: Louis JANG <louis@mizi.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Dave Young <hidave.darkstar@gmail.com>,
linux-bluetooth@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
bmidgley@gmail.com, David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [Bluez-devel] forcing SCO connection patch
Date: Tue, 26 Feb 2008 12:53:36 +0900 [thread overview]
Message-ID: <47C38D40.3040809@mizi.com> (raw)
In-Reply-To: <70692DDF-93B7-447E-ABEE-3CDBD94F15F1@holtmann.org>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
Hi Marcel
>> --- linux-2.6.23/net/bluetooth/hci_event.c.orig 2008-02-25
>> 17:17:11.000000000 +0900
>> +++ linux-2.6.23/net/bluetooth/hci_event.c 2008-02-25
>> 17:30:23.000000000 +0900
>> @@ -1313,8 +1313,17 @@
>> hci_dev_lock(hdev);
>>
>> conn = hci_conn_hash_lookup_ba(hdev, ev->link_type, &ev->bdaddr);
>> - if (!conn)
>> - goto unlock;
>> + if (!conn) {
>> + if (ev->link_type != ACL_LINK) {
>> + __u8 link_type = (ev->link_type == ESCO_LINK) ? SCO_LINK : ESCO_LINK;
>> +
>> + conn = hci_conn_hash_lookup_ba(hdev, link_type, &ev->bdaddr);
>> + if (conn)
>> + conn->type = ev->link_type;
>> + }
>> + if (!conn)
>> + goto unlock;
>> + }
>
> NAK. There is no need to check for ACL_LINK. The sync_complete will
> only be called for SCO or eSCO connections.
I see. I removed this check line in the patch.
Thanks.
Louis JANG
[-- Attachment #2: patch_hci_event.c4 --]
[-- Type: text/plain, Size: 647 bytes --]
Signed-off-by: Louis JANG <louis@mizi.com>
--- linux-2.6.23/net/bluetooth/hci_event.c.orig 2008-02-26 12:46:36.000000000 +0900
+++ linux-2.6.23/net/bluetooth/hci_event.c 2008-02-26 12:47:23.000000000 +0900
@@ -1313,8 +1313,15 @@
hci_dev_lock(hdev);
conn = hci_conn_hash_lookup_ba(hdev, ev->link_type, &ev->bdaddr);
- if (!conn)
- goto unlock;
+ if (!conn) {
+ __u8 link_type = (ev->link_type == ESCO_LINK) ? SCO_LINK : ESCO_LINK;
+
+ conn = hci_conn_hash_lookup_ba(hdev, link_type, &ev->bdaddr);
+ if (conn)
+ conn->type = ev->link_type;
+ else
+ goto unlock;
+ }
if (!ev->status) {
conn->handle = __le16_to_cpu(ev->handle);
next prev parent reply other threads:[~2008-02-26 3:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47666E1F.2000902@mizi.com>
[not found] ` <a8e1da0802242330l765b8b1ava62b857baf8a5568@mail.gmail.com>
2008-02-25 7:34 ` [Bluez-devel] forcing SCO connection patch Dave Young
[not found] ` <a8e1da0802242334v23a60cb4q1953b5caf5eb9947-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-02-25 8:26 ` Dave Young
[not found] ` <47C28A33.4070102@mizi.com>
[not found] ` <47C28A33.4070102-6CAt/Z4uMM0@public.gmane.org>
2008-02-25 9:55 ` Dave Young
[not found] ` <a8e1da0802250155u1b7af481va203849f68d9106b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-02-25 11:35 ` Louis JANG
[not found] ` <47C2A7FA.2060902-6CAt/Z4uMM0@public.gmane.org>
2008-02-26 3:07 ` Marcel Holtmann
2008-02-26 3:53 ` Louis JANG [this message]
[not found] ` <47C38D40.3040809-6CAt/Z4uMM0@public.gmane.org>
2008-02-26 19:43 ` Marcel Holtmann
[not found] ` <B96BD3FE-F490-4AD5-9315-ECD42CE9C728-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2008-02-27 1:58 ` Louis JANG
2008-02-27 9:57 ` Marcel Holtmann
2008-02-27 12:21 ` Louis JANG
[not found] ` <47C555E5.2000903-6CAt/Z4uMM0@public.gmane.org>
2008-02-27 15:21 ` Marcel Holtmann
[not found] ` <5D9353FF-6A69-4039-9033-C0EBD1CDA756-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2008-02-28 2:49 ` Louis JANG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C38D40.3040809@mizi.com \
--to=louis@mizi.com \
--cc=bmidgley@gmail.com \
--cc=davem@davemloft.net \
--cc=hidave.darkstar@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).