From: Li Yewang <lyw@cn.fujitsu.com>
To: davem@davemloft.net, swhiteho@redhat.com, netdev@vger.kernel.org
Subject: [PATCH] Can not send icmp netunreach packet
Date: Tue, 26 Feb 2008 14:34:01 +0800 [thread overview]
Message-ID: <47C3B2D9.9090601@cn.fujitsu.com> (raw)
Hi All
There is a bug about icmp netunreach.
If the kernel does not find a route for a packet,
it must send a icmp netunreach packet to the source host,
and discard the packet. But the kernel does not send
a icmp netunreach packet because of the fib_lookup
return value of -ESRCH when a route is not found.
Signed-off-by: Li Yewang <lyw@cn.fujitsu.com>
diff -Nurp net/core_back/fib_rules.c net/core/fib_rules.c
--- net/core_back/fib_rules.c 2008-02-25 13:15:37.000000000 +0800
+++ net/core/fib_rules.c 2008-02-25 13:16:01.000000000 +0800
@@ -188,7 +188,7 @@ jumped:
}
}
- err = -ESRCH;
+ err = -ENETUNREACH;
out:
rcu_read_unlock();
next reply other threads:[~2008-02-26 6:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 6:34 Li Yewang [this message]
2008-02-26 7:35 ` [PATCH] Can not send icmp netunreach packet Jarek Poplawski
2008-02-26 9:59 ` Wei Yongjun
2008-02-26 10:55 ` Jarek Poplawski
2008-02-26 15:34 ` Stephen Hemminger
2008-02-26 21:30 ` David Miller
2008-02-26 22:44 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C3B2D9.9090601@cn.fujitsu.com \
--to=lyw@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).