From: Patrick McHardy <kaber@trash.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [NET]: Messed multicast lists after dev_mc_sync/unsync
Date: Wed, 27 Feb 2008 12:46:41 +0100 [thread overview]
Message-ID: <47C54DA1.5070402@trash.net> (raw)
In-Reply-To: <1204112235.3729.54.camel@johannes.berg>
Johannes Berg wrote:
>
>
>> Commit a0a400d79e3dd7843e7e81baa3ef2957bdc292d0 from you
>> introduced a new field "da_synced" to struct dev_addr_list that is
>> not properly initialized to 0. So when any of the current users (8021q,
>> macvlan, mac80211) calls dev_mc_sync/unsync they mess the address
>> list for both devices.
>>
>> - da = kmalloc(sizeof(*da), GFP_ATOMIC);
>> + da = kzalloc(sizeof(*da), GFP_ATOMIC);
>>
>
> Could this be the reason for us seeing "multicast address leakage"
> warnings?
I don't think so, the users field was already initialized properly
before. Is wireless using dev_unicast_sync or dev_mc_sync?
next prev parent reply other threads:[~2008-02-27 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 14:56 [NET]: Messed multicast lists after dev_mc_sync/unsync Patrick McHardy
2008-02-19 22:17 ` David Miller
2008-02-27 7:38 ` Pekka Savola
2008-02-27 7:52 ` David Miller
2008-02-27 11:37 ` Johannes Berg
2008-02-27 11:46 ` Patrick McHardy [this message]
2008-02-27 12:34 ` Johannes Berg
2008-02-27 12:42 ` Patrick McHardy
2008-02-27 12:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C54DA1.5070402@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).