* [PATCH 07/15] [LLC]: Use proc_create() to setup ->proc_fops first
@ 2008-02-28 10:56 Wang Chen
2008-02-28 22:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wang Chen @ 2008-02-28 10:56 UTC (permalink / raw)
To: David S. Miller, NETDEV
Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
---
net/llc/llc_proc.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/net/llc/llc_proc.c b/net/llc/llc_proc.c
index cb34bc0..48212c0 100644
--- a/net/llc/llc_proc.c
+++ b/net/llc/llc_proc.c
@@ -239,18 +239,14 @@ int __init llc_proc_init(void)
goto out;
llc_proc_dir->owner = THIS_MODULE;
- p = create_proc_entry("socket", S_IRUGO, llc_proc_dir);
+ p = proc_create("socket", S_IRUGO, llc_proc_dir, &llc_seq_socket_fops);
if (!p)
goto out_socket;
- p->proc_fops = &llc_seq_socket_fops;
-
- p = create_proc_entry("core", S_IRUGO, llc_proc_dir);
+ p = proc_create("core", S_IRUGO, llc_proc_dir, &llc_seq_core_fops);
if (!p)
goto out_core;
- p->proc_fops = &llc_seq_core_fops;
-
rc = 0;
out:
return rc;
--
WCN
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 07/15] [LLC]: Use proc_create() to setup ->proc_fops first
2008-02-28 10:56 [PATCH 07/15] [LLC]: Use proc_create() to setup ->proc_fops first Wang Chen
@ 2008-02-28 22:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-02-28 22:09 UTC (permalink / raw)
To: wangchen; +Cc: netdev
From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Thu, 28 Feb 2008 18:56:54 +0800
> Use proc_create() to make sure that ->proc_fops be setup before gluing
> PDE to main tree.
>
> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-28 22:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-28 10:56 [PATCH 07/15] [LLC]: Use proc_create() to setup ->proc_fops first Wang Chen
2008-02-28 22:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).