From: Eric Dumazet <dada1@cosmosbay.com>
To: Patrick McManus <mcmanus@ducksong.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: RFC [PATCH 2/3] TCP_DEFER_ACCEPT updates: don't retransmit syn-ack while waiting for first data byte
Date: Sat, 01 Mar 2008 11:42:51 +0100 [thread overview]
Message-ID: <47C9332B.4050207@cosmosbay.com> (raw)
In-Reply-To: <1204076945.15970.35.camel@tng>
Patrick McManus a écrit :
> Signed-off-by: Patrick McManus <mcmanus@ducksong.com>
>
> a socket in LISTEN that had completed its 3 way handshake, but not notified
> userspace because of SO_DEFER_ACCEPT, would retransmit the already
> acked syn-ack during the time it was waiting for the first data byte
> from the peer.
>
> diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
> index 03cc323..7216f5e 100644
> --- a/net/ipv4/inet_connection_sock.c
> +++ b/net/ipv4/inet_connection_sock.c
> @@ -461,8 +461,9 @@ void inet_csk_reqsk_queue_prune(struct sock *parent,
> reqp=&lopt->syn_table[i];
> while ((req = *reqp) != NULL) {
> if (time_after_eq(now, req->expires)) {
> - if ((req->retrans < (inet_rsk(req)->acked ? max_retries : thresh))
> - && !req->rsk_ops->rtx_syn_ack(parent, req, NULL)) {
> + if ((req->retrans < (inet_rsk(req)->acked ? max_retries : thresh))
> + && (inet_rsk(req)->acked ||
> + !req->rsk_ops->rtx_syn_ack(parent, req, NULL))) {
> unsigned long timeo;
>
> if (req->retrans++ == 0)
>
>
Acked-by: Eric Dumazet <dada1@cosmosbay.com>
prev parent reply other threads:[~2008-03-01 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 1:49 RFC [PATCH 2/3] TCP_DEFER_ACCEPT updates: don't retransmit syn-ack while waiting for first data byte Patrick McManus
2008-03-01 10:42 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C9332B.4050207@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=mcmanus@ducksong.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).