From: Arnd Hannemann <hannemann@nets.rwth-aachen.de>
To: netdev@vger.kernel.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Removing unneeded statement from tcp_ipv4.c
Date: Mon, 03 Mar 2008 14:23:38 +0100 [thread overview]
Message-ID: <47CBFBDA.7000801@nets.rwth-aachen.de> (raw)
Avoid setting tstamp_ok because this is done two lines later anyway.
Signed-off-by: Arnd Hannemann <hannemann@nets.rwth-aachen.de>
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 00156bf..a28c4c2 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -1302,15 +1302,14 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
tmp_opt.saw_tstamp = 0;
}
- if (tmp_opt.saw_tstamp && !tmp_opt.rcv_tsval) {
+ if (tmp_opt.saw_tstamp && !tmp_opt.rcv_tsval)
/* Some OSes (unknown ones, but I see them on web server, which
* contains information interesting only for windows'
* users) do not send their stamp in SYN. It is easy case.
* We simply do not advertise TS support.
*/
tmp_opt.saw_tstamp = 0;
- tmp_opt.tstamp_ok = 0;
- }
+
tmp_opt.tstamp_ok = tmp_opt.saw_tstamp;
tcp_openreq_init(req, &tmp_opt, skb);
next reply other threads:[~2008-03-03 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 13:23 Arnd Hannemann [this message]
2008-03-03 14:08 ` [PATCH] Removing unneeded statement from tcp_ipv4.c Ilpo Järvinen
2008-03-03 23:18 ` [PATCH-RESEND] " Arnd Hannemann
2008-03-06 3:00 ` David Miller
2008-03-06 10:46 ` Arnd Hannemann
2008-03-03 18:51 ` [PATCH] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CBFBDA.7000801@nets.rwth-aachen.de \
--to=hannemann@nets.rwth-aachen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).