Remove usage of C++ keyword 'class' on htb.h header

Remove usage of C++ keyword 'class' on htb.h header

[Rui Tiago Cação Matos]

My previous email didn't have the patch inlined.

[PATCH] Remove usage of C++ keyword 'class' on htb.h header.

[Rui Tiago Cação Matos]

Signed-off-by: Rui Tiago Cação Matos <rmatos@av.it.pt>
---
 include/netlink/route/sch/htb.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/netlink/route/sch/htb.h b/include/netlink/route/sch/htb.h
index 5d4d681..d44f039 100644
--- a/include/netlink/route/sch/htb.h
+++ b/include/netlink/route/sch/htb.h
@@ -30,9 +30,9 @@ extern void rtnl_htb_set_rate(struct rtnl_class *, uint32_t);
 extern void rtnl_htb_set_ceil(struct rtnl_class *, uint32_t);
 extern void rtnl_htb_set_rbuffer(struct rtnl_class *, uint32_t);
 extern void rtnl_htb_set_cbuffer(struct rtnl_class *, uint32_t);
-extern void rtnl_htb_set_quantum(struct rtnl_class *class, uint32_t quantum);
-extern void rtnl_htb_set_overhead(struct rtnl_class *class, uint8_t overhead);
-extern void rtnl_htb_set_mpu(struct rtnl_class *class, uint8_t mpu);
+extern void rtnl_htb_set_quantum(struct rtnl_class *, uint32_t quantum);
+extern void rtnl_htb_set_overhead(struct rtnl_class *, uint8_t overhead);
+extern void rtnl_htb_set_mpu(struct rtnl_class *, uint8_t mpu);
 
 #ifdef __cplusplus
 }
-- 
1.5.4.1

Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header.

[Randy Dunlap]

On Tue,  4 Mar 2008 18:31:16 +0000 Rui Tiago Cação Matos wrote:

> Signed-off-by: Rui Tiago Cação Matos <rmatos@av.it.pt>
> ---
>  include/netlink/route/sch/htb.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/netlink/route/sch/htb.h b/include/netlink/route/sch/htb.h
> index 5d4d681..d44f039 100644
> --- a/include/netlink/route/sch/htb.h
> +++ b/include/netlink/route/sch/htb.h
> @@ -30,9 +30,9 @@ extern void rtnl_htb_set_rate(struct rtnl_class *, uint32_t);
>  extern void rtnl_htb_set_ceil(struct rtnl_class *, uint32_t);
>  extern void rtnl_htb_set_rbuffer(struct rtnl_class *, uint32_t);
>  extern void rtnl_htb_set_cbuffer(struct rtnl_class *, uint32_t);
> -extern void rtnl_htb_set_quantum(struct rtnl_class *class, uint32_t quantum);
> -extern void rtnl_htb_set_overhead(struct rtnl_class *class, uint8_t overhead);
> -extern void rtnl_htb_set_mpu(struct rtnl_class *class, uint8_t mpu);
> +extern void rtnl_htb_set_quantum(struct rtnl_class *, uint32_t quantum);
> +extern void rtnl_htb_set_overhead(struct rtnl_class *, uint8_t overhead);
> +extern void rtnl_htb_set_mpu(struct rtnl_class *, uint8_t mpu);
>  
>  #ifdef __cplusplus
>  }


We generally prefer to see function parameter names present in prototypes.

What about the other 30 or so C++ keywords that the kernel uses?
Do you have a metric ton of more patches?

---
~Randy

Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header.

[Rui Tiago Cação Matos]

On 04/03/2008, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> We generally prefer to see function parameter names present in prototypes.
>
>  What about the other 30 or so C++ keywords that the kernel uses?
>  Do you have a metric ton of more patches?

Sorry if I wasn't clear. This is for the userspace libnl.

Rui

Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header.

[Randy Dunlap]

Rui Tiago Cação Matos wrote:
> On 04/03/2008, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> We generally prefer to see function parameter names present in prototypes.
>>
>>  What about the other 30 or so C++ keywords that the kernel uses?
>>  Do you have a metric ton of more patches?
> 
> Sorry if I wasn't clear. This is for the userspace libnl.

Oh.  Ah.  Sorry about that.  Thanks for the clarification.

-- 
~Randy

Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header.

[Thomas Graf]

* Rui Tiago Ca??o Matos <rmatos@av.it.pt> 2008-03-04 18:31
> Signed-off-by: Rui Tiago Cação Matos <rmatos@av.it.pt>

Applied, thanks.

Is this the only change required to make all the headers c++ safe?

Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header.

[Rui Tiago Cação Matos]

On 05/03/2008, Thomas Graf <tgraf@suug.ch> wrote:
>  Is this the only change required to make all the headers c++ safe?

I'm quite sure there are no more headers using the 'class' keyword. As
I find more problems I'll keep you posted. A simple .cpp file
including all of the netlink/ headers fails to compile with messages
like

'__u32' does not name a type

I suppose there are implicit header dependencies but I'm not familiar
enough with libnl yet to say.

BTW, there isn't a catch all header in libnl, is there?

Rui