* Remove usage of C++ keyword 'class' on htb.h header @ 2008-03-04 18:31 Rui Tiago Cação Matos 2008-03-04 18:31 ` [PATCH] " Rui Tiago Cação Matos 0 siblings, 1 reply; 7+ messages in thread From: Rui Tiago Cação Matos @ 2008-03-04 18:31 UTC (permalink / raw) To: tgraf; +Cc: netdev My previous email didn't have the patch inlined. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Remove usage of C++ keyword 'class' on htb.h header. 2008-03-04 18:31 Remove usage of C++ keyword 'class' on htb.h header Rui Tiago Cação Matos @ 2008-03-04 18:31 ` Rui Tiago Cação Matos 2008-03-04 20:53 ` Randy Dunlap 2008-03-05 12:42 ` Thomas Graf 0 siblings, 2 replies; 7+ messages in thread From: Rui Tiago Cação Matos @ 2008-03-04 18:31 UTC (permalink / raw) To: tgraf; +Cc: netdev, Rui Tiago Cação Matos Signed-off-by: Rui Tiago Cação Matos <rmatos@av.it.pt> --- include/netlink/route/sch/htb.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/netlink/route/sch/htb.h b/include/netlink/route/sch/htb.h index 5d4d681..d44f039 100644 --- a/include/netlink/route/sch/htb.h +++ b/include/netlink/route/sch/htb.h @@ -30,9 +30,9 @@ extern void rtnl_htb_set_rate(struct rtnl_class *, uint32_t); extern void rtnl_htb_set_ceil(struct rtnl_class *, uint32_t); extern void rtnl_htb_set_rbuffer(struct rtnl_class *, uint32_t); extern void rtnl_htb_set_cbuffer(struct rtnl_class *, uint32_t); -extern void rtnl_htb_set_quantum(struct rtnl_class *class, uint32_t quantum); -extern void rtnl_htb_set_overhead(struct rtnl_class *class, uint8_t overhead); -extern void rtnl_htb_set_mpu(struct rtnl_class *class, uint8_t mpu); +extern void rtnl_htb_set_quantum(struct rtnl_class *, uint32_t quantum); +extern void rtnl_htb_set_overhead(struct rtnl_class *, uint8_t overhead); +extern void rtnl_htb_set_mpu(struct rtnl_class *, uint8_t mpu); #ifdef __cplusplus } -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header. 2008-03-04 18:31 ` [PATCH] " Rui Tiago Cação Matos @ 2008-03-04 20:53 ` Randy Dunlap 2008-03-04 21:44 ` Rui Tiago Cação Matos 2008-03-05 12:42 ` Thomas Graf 1 sibling, 1 reply; 7+ messages in thread From: Randy Dunlap @ 2008-03-04 20:53 UTC (permalink / raw) To: Rui Tiago Cação Matos; +Cc: tgraf, netdev On Tue, 4 Mar 2008 18:31:16 +0000 Rui Tiago Cação Matos wrote: > Signed-off-by: Rui Tiago Cação Matos <rmatos@av.it.pt> > --- > include/netlink/route/sch/htb.h | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/netlink/route/sch/htb.h b/include/netlink/route/sch/htb.h > index 5d4d681..d44f039 100644 > --- a/include/netlink/route/sch/htb.h > +++ b/include/netlink/route/sch/htb.h > @@ -30,9 +30,9 @@ extern void rtnl_htb_set_rate(struct rtnl_class *, uint32_t); > extern void rtnl_htb_set_ceil(struct rtnl_class *, uint32_t); > extern void rtnl_htb_set_rbuffer(struct rtnl_class *, uint32_t); > extern void rtnl_htb_set_cbuffer(struct rtnl_class *, uint32_t); > -extern void rtnl_htb_set_quantum(struct rtnl_class *class, uint32_t quantum); > -extern void rtnl_htb_set_overhead(struct rtnl_class *class, uint8_t overhead); > -extern void rtnl_htb_set_mpu(struct rtnl_class *class, uint8_t mpu); > +extern void rtnl_htb_set_quantum(struct rtnl_class *, uint32_t quantum); > +extern void rtnl_htb_set_overhead(struct rtnl_class *, uint8_t overhead); > +extern void rtnl_htb_set_mpu(struct rtnl_class *, uint8_t mpu); > > #ifdef __cplusplus > } We generally prefer to see function parameter names present in prototypes. What about the other 30 or so C++ keywords that the kernel uses? Do you have a metric ton of more patches? --- ~Randy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header. 2008-03-04 20:53 ` Randy Dunlap @ 2008-03-04 21:44 ` Rui Tiago Cação Matos 2008-03-04 21:50 ` Randy Dunlap 0 siblings, 1 reply; 7+ messages in thread From: Rui Tiago Cação Matos @ 2008-03-04 21:44 UTC (permalink / raw) To: Randy Dunlap; +Cc: tgraf, netdev On 04/03/2008, Randy Dunlap <randy.dunlap@oracle.com> wrote: > We generally prefer to see function parameter names present in prototypes. > > What about the other 30 or so C++ keywords that the kernel uses? > Do you have a metric ton of more patches? Sorry if I wasn't clear. This is for the userspace libnl. Rui ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header. 2008-03-04 21:44 ` Rui Tiago Cação Matos @ 2008-03-04 21:50 ` Randy Dunlap 0 siblings, 0 replies; 7+ messages in thread From: Randy Dunlap @ 2008-03-04 21:50 UTC (permalink / raw) To: Rui Tiago Cação Matos; +Cc: tgraf, netdev Rui Tiago Cação Matos wrote: > On 04/03/2008, Randy Dunlap <randy.dunlap@oracle.com> wrote: >> We generally prefer to see function parameter names present in prototypes. >> >> What about the other 30 or so C++ keywords that the kernel uses? >> Do you have a metric ton of more patches? > > Sorry if I wasn't clear. This is for the userspace libnl. Oh. Ah. Sorry about that. Thanks for the clarification. -- ~Randy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header. 2008-03-04 18:31 ` [PATCH] " Rui Tiago Cação Matos 2008-03-04 20:53 ` Randy Dunlap @ 2008-03-05 12:42 ` Thomas Graf 2008-03-05 14:41 ` Rui Tiago Cação Matos 1 sibling, 1 reply; 7+ messages in thread From: Thomas Graf @ 2008-03-05 12:42 UTC (permalink / raw) To: Rui Tiago Cação Matos; +Cc: netdev * Rui Tiago Ca??o Matos <rmatos@av.it.pt> 2008-03-04 18:31 > Signed-off-by: Rui Tiago Cação Matos <rmatos@av.it.pt> Applied, thanks. Is this the only change required to make all the headers c++ safe? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header. 2008-03-05 12:42 ` Thomas Graf @ 2008-03-05 14:41 ` Rui Tiago Cação Matos 0 siblings, 0 replies; 7+ messages in thread From: Rui Tiago Cação Matos @ 2008-03-05 14:41 UTC (permalink / raw) To: Thomas Graf; +Cc: netdev On 05/03/2008, Thomas Graf <tgraf@suug.ch> wrote: > Is this the only change required to make all the headers c++ safe? I'm quite sure there are no more headers using the 'class' keyword. As I find more problems I'll keep you posted. A simple .cpp file including all of the netlink/ headers fails to compile with messages like '__u32' does not name a type I suppose there are implicit header dependencies but I'm not familiar enough with libnl yet to say. BTW, there isn't a catch all header in libnl, is there? Rui ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-03-05 14:41 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-03-04 18:31 Remove usage of C++ keyword 'class' on htb.h header Rui Tiago Cação Matos 2008-03-04 18:31 ` [PATCH] " Rui Tiago Cação Matos 2008-03-04 20:53 ` Randy Dunlap 2008-03-04 21:44 ` Rui Tiago Cação Matos 2008-03-04 21:50 ` Randy Dunlap 2008-03-05 12:42 ` Thomas Graf 2008-03-05 14:41 ` Rui Tiago Cação Matos
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).