From: Daniel Lezcano <dlezcano@fr.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, benjamin.thery@bull.net
Subject: Re: [patch 0/9][NETNS][IPV6] make addrconf and icmp per namespace
Date: Wed, 05 Mar 2008 20:55:08 +0100 [thread overview]
Message-ID: <47CEFA9C.3000800@fr.ibm.com> (raw)
In-Reply-To: <20080305.111308.05959072.davem@davemloft.net>
David Miller wrote:
> From: Daniel Lezcano <dlezcano@fr.ibm.com>
> Date: Wed, 05 Mar 2008 18:56:49 +0100
>
>> The following patchset makes the different part of ipv6 to take
>> into account the namespaces. On top of that, addrconf and icmp
>> are now aware how to use the namespaces too. So we can move an
>> interface inside the namespace and set ip up to have an ipv6
>> address autoconfigured and be able to ping it.
>>
>> ndisc will come very soon ... :)
>
> Applied and pushed out to net-2.6.26, thanks.
>
> Can you quickly resolve this turd which got added by
> these changes to net/ipv6/addrconf.c?
>
> static void addrconf_net_exit(struct net *net)
> {
> struct net_device *dev;
>
> /*
> * Remove loopback references from default routing entries
> */
> /* in6_dev_put(net->ipv6.ip6_null_entry->rt6i_idev); */
> /* #ifdef CONFIG_IPV6_MULTIPLE_TABLES */
> /* in6_dev_put(net->ipv6.ip6_prohibit_entry->rt6i_idev); */
> /* in6_dev_put(net->ipv6.ip6_blk_hole_entry->rt6i_idev); */
> /* #endif */
>
> Either turn the code on or remove it.
>
> The upstream tree isn't a place to take "notes" using commented out
> code to remind you later about something.
Oops, sorry. I forgot to remove this comment. I will remove it asap.
prev parent reply other threads:[~2008-03-05 19:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 17:56 [patch 0/9][NETNS][IPV6] make addrconf and icmp per namespace Daniel Lezcano
2008-03-05 17:56 ` [patch 1/9][NETNS][IPV6] Move sysctl initialization later on in the IPv6 init sequence Daniel Lezcano
2008-03-05 17:56 ` [patch 2/9][NETNS][IPV6] af_inet6 - allow socket creation per namespace Daniel Lezcano
2008-03-05 17:56 ` [patch 3/9][NETNS][IPV6] proc - protect snmp6 from non-init_net calls Daniel Lezcano
2008-03-05 17:56 ` [patch 4/9][NETNS][IPV6] addrconf - Pass the proper network namespace parameters to addrconf Daniel Lezcano
2008-03-05 17:56 ` [patch 5/9][NETNS][IPV6] addrconf - make addrconf per namespace Daniel Lezcano
2008-03-05 17:56 ` [patch 6/9][NETNS][IPV6] route6 - add netns parameter to ip6_route_output Daniel Lezcano
2008-03-05 17:56 ` [patch 7/9][NETNS][IPV6] route6 - pass always a valid socket to ip6_dst_lookup Daniel Lezcano
2008-03-05 17:56 ` [patch 8/9][NETNS][IPV6] ip6_input - enable ipv6_rcv to handle several network namespace Daniel Lezcano
2008-03-05 17:56 ` [patch 9/9][NETNS][IPV6] icmp6 - make icmpv6_socket per namespace Daniel Lezcano
2008-03-05 19:13 ` [patch 0/9][NETNS][IPV6] make addrconf and icmp " David Miller
2008-03-05 19:55 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CEFA9C.3000800@fr.ibm.com \
--to=dlezcano@fr.ibm.com \
--cc=benjamin.thery@bull.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).