netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [E1000-devel] [PATCH 2/4] [RFC] e1000: make ioport free for	supported devices
Date: Thu, 06 Mar 2008 11:35:17 -0800	[thread overview]
Message-ID: <47D04775.7020002@intel.com> (raw)
In-Reply-To: <47CE84BB.1010408@garzik.org>

Jeff Garzik wrote:
> Auke Kok wrote:
>> From: Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>
>>
>> Most e1000 devices do not need ioport access to function properly.
>> This is desirable for a few massive homed systems where ioport
>> resources become constrained.
>>
>> This patch is based on the code from Tomohiro Kusumi, heavily
>> modified to fit PCI API changes and e1000 driver changes.
>>
>> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>
>> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> 
> I don't think you need pci_select_bars()?  It should just be 
> pci_enable_device_mem() in both paths AFAICS...

honestly I don't know :) - I'll look into it. if that's the case then the patch
will change significantly.

thanks,

Auke

  reply	other threads:[~2008-03-06 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-03 22:37 [PATCH 1/4] e100: Do suspend/shutdown like e1000 Auke Kok
2008-03-03 22:37 ` [PATCH 2/4] [RFC] e1000: make ioport free for supported devices Auke Kok
2008-03-05 11:32   ` Jeff Garzik
2008-03-06 19:35     ` Kok, Auke [this message]
2008-03-03 22:37 ` [PATCH 3/4] ixgbe: fix typo in speed mesage Auke Kok
2008-03-03 22:37 ` [PATCH 4/4] Intel ethernet adapter: Update MAINTAINERS Auke Kok
2008-03-03 22:48   ` [E1000-devel] " Kok, Auke
2008-03-05 12:18 ` [PATCH 1/4] e100: Do suspend/shutdown like e1000 Jeff Garzik
2008-03-05 12:18   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D04775.7020002@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).